Message ID | 20250317151236.536673-1-zhao1.liu@intel.com (mailing list archive) |
---|---|
Headers | show |
Series | rust/vmstate: Clean up, fix, enhance & test | expand |
On Mon, Mar 17, 2025 at 3:52 PM Zhao Liu <zhao1.liu@intel.com> wrote: > Hi, > > This series is in preparation for HPET migration support (in particular, > to support varray and vmstate_validate), and it also cleans up and fixes > the current vmstate! However, there is still the gap from being a ‘stable’ > vmstate. Already a great improvement! I quickly went through things that I was planning to do in a slightly different way, but overall this is great work. Give me a day or two to finish reviewing and testing, most of it can already be applied to qemu-rust or even to 10.0. Thanks, Paolo
On Mon, Mar 17, 2025 at 06:20:15PM +0100, Paolo Bonzini wrote: > Date: Mon, 17 Mar 2025 18:20:15 +0100 > From: Paolo Bonzini <pbonzini@redhat.com> > Subject: Re: [PATCH 00/17] rust/vmstate: Clean up, fix, enhance & test > > On Mon, Mar 17, 2025 at 3:52 PM Zhao Liu <zhao1.liu@intel.com> wrote: > > Hi, > > > > This series is in preparation for HPET migration support (in particular, > > to support varray and vmstate_validate), and it also cleans up and fixes > > the current vmstate! However, there is still the gap from being a ‘stable’ > > vmstate. > > Already a great improvement! > > I quickly went through things that I was planning to do in a slightly > different way, but overall this is great work. Give me a day or two > to finish reviewing and testing, most of it can already be applied to > qemu-rust or even to 10.0. Thanks for your quick feedback! I think the main open now is about the best way to implement `field_exists`... pls see my patch 13 reply. I can quickly refresh v2 to help you apply! Regards, Zhao