[v4,0/4] target/loongarch: Solve some issues reported from coccinelle

Message

bibo mao March 19, 2025, 2:08 a.m. UTC

This patch set solves errors reported by coccinelle tool with commands:
  spatch --sp-file scripts/coccinelle/*.cocci --dir target/loongarch/
  spatch --sp-file scripts/coccinelle/*.cocci --dir hw/loongarch/

The main problem is that qemu should fail to run when feature is forced
to enabled however KVM does not support it, rather than report error and
continue to run.

---
  v3 ... v4:
    1. Add missed this cleanup with error and remove some local error
       object.
    2. Replace local error object with error_abort object in
       virt_cpu_irq_init(), since its return value is not checked.

  v2 ... v3:
    1. Add missing modification replacing error_propagate() + error_setg()
      with error_setg().
    2. Some enhancement about error handling, handling error
       symmetrically in many places

  v1 ... v2:
    1. Add fixes tag and change title with fix prefix in patch 1.
    2. Replace error_propagate() with error_setg(), and return directly
       for any error.
---
Bibo Mao (4):
  target/loongarch: Fix error handling of KVM feature checks
  hw/loongarch/virt: Remove unnecessary NULL pointer
  target/loongarch: Remove unnecessary temporary variable assignment
  target/loongarch: Set dest error with error_abort in virt_cpu_irq_init

 hw/loongarch/virt.c               | 40 +++++++++++++------------------
 target/loongarch/kvm/kvm.c        |  8 +++++--
 target/loongarch/tcg/tlb_helper.c |  5 ++--
 3 files changed, 24 insertions(+), 29 deletions(-)


base-commit: 1dae461a913f9da88df05de6e2020d3134356f2e