| Message ID | 20250403081633.158591-1-prantoran@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update | expand |
On Thu, Apr 03, 2025 at 01:16:31AM -0700, Pinku Deb Nath wrote: > The testing with "-t writeback" works for turning on enable_write_cache. > I renamed the function to qemu_pwritev_fua() and fixed any typos. > > I moved the handle_aiocb_flush() into the qemu_pwritev_fua() and > removed from the previously todo seciont. Initially I thought > of only passing aiocb, but then I was not sure whethe I could > derive buf from aiocb, so I added arguments for iovec and iovcnt > into qemu_pwritev_fua(). > > For handling buf in handle_aiocb_rw_linear(), I created iovec > and passed its reference. I assumed that there will be only one > buffer/iovec, so I passed 1 for iovcnt. > > Signed-off-by: Pinku Deb Nath <prantoran@gmail.com> > > Pinku Deb Nath (2): > block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA > block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update > > block/file-posix.c | 54 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 42 insertions(+), 12 deletions(-) Thanks for sending this updates patch series. Please squash changes in the future instead of appending them as separate commits. This means editing previous commits (e.g. git rebase -i master) so that they contain changes made after code review. So if commit 1 is '+ printf("foo\n")', then instead of adding commit 2 to add a semi-colon to the end of the line, just edit the commit so it is '+ printf("foo\n");' in v2 of your patch. One reason to squash changes is so that git-bisect(1) works. Without squashing, there will be intermediate commits that are broken and maybe don't even compile. git-bisect(1) is only usable when each commit compiles and passes tests. Reviews also tend to prefer to see the final state of commits so they don't have to review every incremental edit that was made (often replacing code they already reviewed). It saves them time. Thanks, Stefan
The testing with "-t writeback" works for turning on enable_write_cache. I renamed the function to qemu_pwritev_fua() and fixed any typos. I moved the handle_aiocb_flush() into the qemu_pwritev_fua() and removed from the previously todo seciont. Initially I thought of only passing aiocb, but then I was not sure whethe I could derive buf from aiocb, so I added arguments for iovec and iovcnt into qemu_pwritev_fua(). For handling buf in handle_aiocb_rw_linear(), I created iovec and passed its reference. I assumed that there will be only one buffer/iovec, so I passed 1 for iovcnt. Signed-off-by: Pinku Deb Nath <prantoran@gmail.com> Pinku Deb Nath (2): block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA - update block/file-posix.c | 54 +++++++++++++++++++++++++++++++++++----------- 1 file changed, 42 insertions(+), 12 deletions(-)