From patchwork Thu Mar 28 16:25:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alberto Garcia X-Patchwork-Id: 10875301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9191186D for ; Thu, 28 Mar 2019 16:29:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9439428742 for ; Thu, 28 Mar 2019 16:29:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 884B3287EF; Thu, 28 Mar 2019 16:29:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 34FE128742 for ; Thu, 28 Mar 2019 16:29:23 +0000 (UTC) Received: from localhost ([127.0.0.1]:39069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Xu6-0003we-JE for patchwork-qemu-devel@patchwork.kernel.org; Thu, 28 Mar 2019 12:29:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Xqk-0001ba-E1 for qemu-devel@nongnu.org; Thu, 28 Mar 2019 12:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9Xqj-0004Nc-9N for qemu-devel@nongnu.org; Thu, 28 Mar 2019 12:25:54 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:33973) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9Xqi-0004Mh-TM; Thu, 28 Mar 2019 12:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=0hhGekW2xEriQ2F1PZ2KW39m6O4twr4fi002kNqfES4=; b=S6jIRtB/BjnoDT02jAHtij9MHgzXr8o1Aym8WLQZTzytaeZI/jHFeX88JDuw5gOXg7GRzT7EI6QR82t1rOPGFcLe3Sx71Rlfjix4LDwfNRk2YFJDqC/8DmodudKF4rlYT43jXkAe89Cw/ieDX9NmeDrywVgdDeUf23+b6OR2Tf+Xfx7Av5C9FPtJplk1XXj8szUUZBJ25DOnVbAnNOfsI3EnVGNhhjLQyQ+ZnXMJXLE3eiYrkPommMx7GpBdcLcjraOqDVdkdGGxlCTIVt601kqiUhLMTsPnG6Yij2/IgAll7SzrnXRcYKmEDylzpxhKSZVmgPe7K0kwZJve4+BK0w==; Received: from 87-100-202-60.bb.dnainternet.fi ([87.100.202.60] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1h9Xqe-0007VI-Da; Thu, 28 Mar 2019 17:25:48 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1h9XqR-0003Xw-9J; Thu, 28 Mar 2019 18:25:35 +0200 From: Alberto Garcia To: qemu-devel@nongnu.org Date: Thu, 28 Mar 2019 18:25:08 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH for-4.0 v2 0/3] freeze the backing chain earlier in stream_start() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-block@nongnu.org, Max Reitz , Andrey Shinkevich Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, this series fixes the bug that I found the other day and described here: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00764.html https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00791.html Patch 2 is the important one, patch 3 is a test case, and patch 1 will allow us to detect this kind of errors earlier. Regards, Berto v2: - Patch 2: Change the rollback order [Vladimir] - Patch 3: Use self.wait_until_completed() [Vladimir] v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg00851.html - Initial version Output of backport-diff against v1: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/3:[----] [--] 'block: continue until base is found in bdrv_freeze_backing_chain() et al' 002/3:[----] [-C] 'block: freeze the backing chain earlier in stream_start()' 003/3:[0017] [FC] 'block: test block-stream with a base node that is used by block-commit' Alberto Garcia (3): block: continue until base is found in bdrv_freeze_backing_chain() et al block: freeze the backing chain earlier in stream_start() block: test block-stream with a base node that is used by block-commit block.c | 21 ++++++++++++++------- block/stream.c | 13 +++++++------ tests/qemu-iotests/030 | 17 +++++++++++++++++ tests/qemu-iotests/030.out | 4 ++-- 4 files changed, 40 insertions(+), 15 deletions(-)