[0/6] Misc display/sm501 clean ups and fixes

Message

BALATON Zoltan May 20, 2020, 1:39 p.m. UTC

Hello,

These are some small clean ups and changes to hopefully improve 2D
engine performance and fix a security bug in it. I've only tested it
lightly, haven't verified if breaking it is still possible. It's also
known to change handling of right to left blits which may not be able
to handle overlaping regions but the only guest known to use it
(AmigaOS on sam460ex) seems to be OK with this so unless this is
proven to be needed I won't try to fix that now, this could be
addressed in later patches.

Regards,
BALATON Zoltan

BALATON Zoltan (6):
  sm501: Convert printf + abort to qemu_log_mask
  sm501: Shorten long variable names in sm501_2d_operation
  sm501: Use BIT(x) macro to shorten constant
  sm501: Clean up local variables in sm501_2d_operation
  sm501: Replace hand written implementation with pixman where possible
  sm501: Remove obsolete changelog and todo comment

 hw/display/sm501.c | 278 +++++++++++++++++++++------------------------
 1 file changed, 131 insertions(+), 147 deletions(-)

Comments

BALATON Zoltan May 20, 2020, 5:55 p.m. UTC | #1

On Wed, 20 May 2020, BALATON Zoltan wrote:
> Hello,
>
> These are some small clean ups and changes to hopefully improve 2D
> engine performance and fix a security bug in it. I've only tested it
> lightly, haven't verified if breaking it is still possible. It's also
> known to change handling of right to left blits which may not be able
> to handle overlaping regions but the only guest known to use it
> (AmigaOS on sam460ex) seems to be OK with this so unless this is
> proven to be needed I won't try to fix that now, this could be
> addressed in later patches.

I've found a case where not handling right to left causes a problem (can 
be reproduced by scrolling window content which will do overlapping blits) 
so this will need some more work but the basic idea can be tested with 
this version.

Does anyone know how the X server or other users of pixman handle this as 
pixman does not seem to have support for other than left to right top to 
bottom blits?

Regards,
BALATON Zoltan