mbox series

[v7,00/32] Add subcluster allocation to qcow2

Message ID cover.1590429901.git.berto@igalia.com (mailing list archive)
Headers show
Series Add subcluster allocation to qcow2 | expand

Message

Alberto Garcia May 25, 2020, 6:08 p.m. UTC
Hi,

this is the same as v6 but with a single fix in patch 23.

Please refer to the cover letter of the first version for a full
description of the patches:

   https://lists.gnu.org/archive/html/qemu-block/2019-10/msg00983.html

The big change (in v6) is that the code does not need to iterate over
every subcluster anymore. There's now a new function called
qcow2_get_subcluster_range_type() that checks a group of subclusters
in one go using cto and ctz operations.

Berto

v7:
- Patch 23: Fix shadowing of the 'type' variable.

v6: https://lists.gnu.org/archive/html/qemu-block/2020-05/msg01583.html
- Patch 07: Fix indentation issues in the documentation [Eric]
- Patch 14: Use half-open intervals for the subcluster macros.
            New method to detected invalid subclusters.
- Patch 15: New patch
- Patch 20: Use a faster method to check the status of a groups of
            subclusters without having to iterate over each one of
            them.
- Patch 21: Optimize count_contiguous_subclusters() by removing the
            iteration over every subcluster.
            Earlier detection of invalid subclusters.
            Minor documentation updates [Eric]
- Patch 25: Update after the macro changes in patch 14
- Patch 28: Update after the macro changes in patch 14
- Patch 29: Change patch order so this goes before patch 30
- Patch 30: Fix rebase conflicts now that compression_type has been
            merged.
            Disable toggling extended_l2 using amend [Eric]
- Patch 32: Many new tests and refactoring

v5: https://lists.gnu.org/archive/html/qemu-block/2020-05/msg00251.html
v4: https://lists.gnu.org/archive/html/qemu-block/2020-03/msg00966.html
v3: https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00587.html
v2: https://lists.gnu.org/archive/html/qemu-block/2019-10/msg01642.html
v1: https://lists.gnu.org/archive/html/qemu-block/2019-10/msg00983.html

Alberto Garcia (32):
  qcow2: Make Qcow2AioTask store the full host offset
  qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset()
  qcow2: Add calculate_l2_meta()
  qcow2: Split cluster_needs_cow() out of count_cow_clusters()
  qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied()
  qcow2: Add get_l2_entry() and set_l2_entry()
  qcow2: Document the Extended L2 Entries feature
  qcow2: Add dummy has_subclusters() function
  qcow2: Add subcluster-related fields to BDRVQcow2State
  qcow2: Add offset_to_sc_index()
  qcow2: Add offset_into_subcluster() and size_to_subclusters()
  qcow2: Add l2_entry_size()
  qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()
  qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()
  qcow2: Add qcow2_get_subcluster_range_type()
  qcow2: Add qcow2_cluster_is_allocated()
  qcow2: Add cluster type parameter to qcow2_get_host_offset()
  qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_*
  qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC
  qcow2: Add subcluster support to calculate_l2_meta()
  qcow2: Add subcluster support to qcow2_get_host_offset()
  qcow2: Add subcluster support to zero_in_l2_slice()
  qcow2: Add subcluster support to discard_in_l2_slice()
  qcow2: Add subcluster support to check_refcounts_l2()
  qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2()
  qcow2: Clear the L2 bitmap when allocating a compressed cluster
  qcow2: Add subcluster support to handle_alloc_space()
  qcow2: Add subcluster support to qcow2_co_pwrite_zeroes()
  qcow2: Add subcluster support to qcow2_measure()
  qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit
  qcow2: Assert that expand_zero_clusters_in_l1() does not support
    subclusters
  iotests: Add tests for qcow2 images with extended L2 entries

 docs/interop/qcow2.txt           |  68 ++-
 docs/qcow2-cache.txt             |  19 +-
 qapi/block-core.json             |   7 +
 block/qcow2.h                    | 203 ++++++-
 include/block/block_int.h        |   1 +
 block/qcow2-cluster.c            | 912 +++++++++++++++++++++----------
 block/qcow2-refcount.c           |  38 +-
 block/qcow2.c                    | 291 ++++++----
 block/trace-events               |   2 +-
 tests/qemu-iotests/031.out       |   8 +-
 tests/qemu-iotests/036.out       |   4 +-
 tests/qemu-iotests/049.out       | 102 ++--
 tests/qemu-iotests/060.out       |   1 +
 tests/qemu-iotests/061           |   6 +
 tests/qemu-iotests/061.out       |  25 +-
 tests/qemu-iotests/065           |  12 +-
 tests/qemu-iotests/082.out       |  48 +-
 tests/qemu-iotests/085.out       |  38 +-
 tests/qemu-iotests/144.out       |   4 +-
 tests/qemu-iotests/182.out       |   2 +-
 tests/qemu-iotests/185.out       |   8 +-
 tests/qemu-iotests/198.out       |   2 +
 tests/qemu-iotests/206.out       |   4 +
 tests/qemu-iotests/242.out       |   5 +
 tests/qemu-iotests/255.out       |   8 +-
 tests/qemu-iotests/271           | 705 ++++++++++++++++++++++++
 tests/qemu-iotests/271.out       | 603 ++++++++++++++++++++
 tests/qemu-iotests/274.out       |  49 +-
 tests/qemu-iotests/280.out       |   2 +-
 tests/qemu-iotests/common.filter |   1 +
 tests/qemu-iotests/group         |   1 +
 31 files changed, 2617 insertions(+), 562 deletions(-)
 create mode 100755 tests/qemu-iotests/271
 create mode 100644 tests/qemu-iotests/271.out

Comments

no-reply@patchew.org May 26, 2020, 2:54 a.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      block/vhdx-log.o
  CC      block/quorum.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=9b1264bbf7da42c889982dca188cc03d', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-ocqmw2al/src/docker-src.2020-05-25-22.52.43.18202:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=9b1264bbf7da42c889982dca188cc03d
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-ocqmw2al/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m7.054s
user    0m7.704s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 26, 2020, 5:17 a.m. UTC | #2
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      block/replication.o
  CC      block/throttle.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=89984ee3f656452a98658b028e2f81ad', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-ih_usmbr/src/docker-src.2020-05-26-01.15.25.15391:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=89984ee3f656452a98658b028e2f81ad
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-ih_usmbr/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    1m31.819s
user    0m7.962s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 26, 2020, 5:48 a.m. UTC | #3
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      block/nvme.o
  CC      block/nbd.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      block/sheepdog.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=54c6e4ef580b4e42910ac145711b9ec8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-zwrcy1ny/src/docker-src.2020-05-26-01.46.21.9081:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=54c6e4ef580b4e42910ac145711b9ec8
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-zwrcy1ny/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m14.685s
user    0m4.384s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 26, 2020, 6:14 a.m. UTC | #4
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      crypto/hmac.o
  CC      crypto/hmac-nettle.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=0ee10aa3a0c34970a37fe42cc4b23599', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-7eq5qsxu/src/docker-src.2020-05-26-02.12.24.26506:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=0ee10aa3a0c34970a37fe42cc4b23599
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-7eq5qsxu/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m1.527s
user    0m7.906s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 26, 2020, 8:01 a.m. UTC | #5
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      chardev/char-null.o
  CC      chardev/char-parallel.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      chardev/char-pipe.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=49de6f81056e4dada8fdcb2f36476d0d', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-ccy1y3ug/src/docker-src.2020-05-26-03.59.02.30650:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=49de6f81056e4dada8fdcb2f36476d0d
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-ccy1y3ug/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m15.319s
user    0m8.116s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 26, 2020, 10:13 a.m. UTC | #6
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      chardev/char-ringbuf.o
  CC      chardev/char-serial.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
     uint64_t expected_offset;
              ^
cc1: all warnings being treated as errors
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      chardev/char-socket.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=5a69132c2e8949c9a1f8075408c7c90b', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-hk0gk3sy/src/docker-src.2020-05-26-06.11.53.30269:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=5a69132c2e8949c9a1f8075408c7c90b
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-hk0gk3sy/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    1m32.430s
user    0m7.816s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Alberto Garcia May 26, 2020, 11:01 a.m. UTC | #7
On Tue 26 May 2020 04:54:50 AM CEST, no-reply@patchew.org wrote:
> /tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
> /tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          } else if (type != expected_type) {
>                    ^

These are all false positives, these variables are never used before
they are initialized.

Berto
no-reply@patchew.org May 26, 2020, 1:08 p.m. UTC | #8
Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.berto@igalia.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      crypto/xts.o
  CC      crypto/block.o
/tmp/qemu-test/src/block/qcow2-cluster.c: In function 'qcow2_get_host_offset':
/tmp/qemu-test/src/block/qcow2-cluster.c:473:19: error: 'expected_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (type != expected_type) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:449:25: note: 'expected_type' was declared here
     QCow2SubclusterType expected_type, type;
                         ^
/tmp/qemu-test/src/block/qcow2-cluster.c:475:19: error: 'check_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         } else if (check_offset) {
                   ^
/tmp/qemu-test/src/block/qcow2-cluster.c:447:10: note: 'check_offset' was declared here
     bool check_offset;
          ^
/tmp/qemu-test/src/block/qcow2-cluster.c:476:29: error: 'expected_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             expected_offset += s->cluster_size;
                             ^
/tmp/qemu-test/src/block/qcow2-cluster.c:448:14: note: 'expected_offset' was declared here
---
              ^
cc1: all warnings being treated as errors
  CC      crypto/block-luks.o
make: *** [block/qcow2-cluster.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      io/channel-buffer.o
  CC      crypto/block-qcow.o
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=5625020d41e74ff5aa8613d320015c10', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-chyxwtdq/src/docker-src.2020-05-26-09.05.43.7203:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=5625020d41e74ff5aa8613d320015c10
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-chyxwtdq/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    2m35.770s
user    0m4.974s


The full log is available at
http://patchew.org/logs/cover.1590429901.git.berto@igalia.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com