mbox series

[v4,0/6] support dirtyrate at the granualrity of vcpu

Message ID cover.1623804189.git.huangy81@chinatelecom.cn (mailing list archive)
Headers show
Series support dirtyrate at the granualrity of vcpu | expand


Hyman June 16, 2021, 1:12 a.m. UTC
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>

- make global_dirty_log a bitmask:
  1. add comments about dirty log bitmask
  2. use assert statement to check validity of flags 
  3. add trace to log bitmask changes

- introduce mode option to show what method calculation should be used,
  also, export mode option in the as last commmit 

- split cleanup and init of dirty rate stat and move it in the main

- change the fields of DirtyPageRecord to uint64_t type so that we
  can calculation the increased dirty pages with the formula
  as Peter's advice: dirty pages = end_pages - start_pages

- introduce mutex to protect dirty rate stat info

- adjust order of registering thread

- drop the memory free callback 

this version modify some code on Peter's advice, reference to: 

thanks again.

- pick up "migration/dirtyrate: make sample page count configurable" to
  make patchset apply master correctly

- rebase to "migration/dirtyrate: make sample page count configurable"

- rename "vcpu" to "per_vcpu" to show the per-vcpu method

- squash patch 5/6 into a single one, squash patch 1/2 also 

- pick up "hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds"

- make global_dirty_log a bitmask to make sure both migration and dirty
  could not intefer with each other

- add memory free callback to prevent memory leaking 

the most different of v2 fron v1 is that we make the global_dirty_log a 
bitmask. the reason is dirty rate measurement may start or stop dirty
logging during calculation. this conflict with migration because stop
dirty log make migration leave dirty pages out then that'll be a

make global_dirty_log a bitmask can let both migration and dirty
rate measurement work fine. introduce GLOBAL_DIRTY_MIGRATION and
GLOBAL_DIRTY_DIRTY_RATE to distinguish what current dirty log aims
for, migration or dirty rate.
all references to global_dirty_log should be untouched because any bit
set there should justify that global dirty logging is enabled.

Please review, thanks !


Since the Dirty Ring on QEMU part has been merged recently, how to use
this feature is under consideration.

In the scene of migration, it is valuable to provide a more accurante
interface to track dirty memory than existing one, so that the upper
layer application can make a wise decision, or whatever. More
dirtyrate info at the granualrity of vcpu could provide a possibility to
make migration convergent by imposing restriction on vcpu. With Dirty
Ring, we can calculate dirtyrate efficiently and cheaply.

The old interface implemented by sampling pages, it consumes cpu 
resource, and the larger guest memory size become, the more cpu resource
it consumes, namely, hard to scale. New interface has no such drawback.

Please review, thanks !

Best Regards !

Hyman Huang(黄勇) (6):
  KVM: introduce dirty_pages and kvm_dirty_ring_enabled
  memory: make global_dirty_log a bitmask
  migration/dirtyrate: introduce struct and adjust DirtyRateStat
  migration/dirtyrate: adjust order of registering thread
  migration/dirtyrate: move init step of calculation to main thread
  migration/dirtyrate: implement dirty-ring dirtyrate calculation

 accel/kvm/kvm-all.c    |   7 ++
 hmp-commands.hx        |   7 +-
 include/exec/memory.h  |  14 ++-
 include/hw/core/cpu.h  |   1 +
 include/sysemu/kvm.h   |   1 +
 migration/dirtyrate.c  | 259 +++++++++++++++++++++++++++++++++++++++++++------
 migration/dirtyrate.h  |  19 +++-
 migration/ram.c        |   8 +-
 migration/trace-events |   2 +
 qapi/migration.json    |  46 ++++++++-
 softmmu/memory.c       |  31 ++++--
 softmmu/trace-events   |   1 +
 12 files changed, 343 insertions(+), 53 deletions(-)