From patchwork Sun Jul 11 20:55:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Straub X-Patchwork-Id: 12369341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D42C07E96 for ; Sun, 11 Jul 2021 20:57:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D657260551 for ; Sun, 11 Jul 2021 20:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D657260551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2gVW-0000lU-SA for qemu-devel@archiver.kernel.org; Sun, 11 Jul 2021 16:56:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2gUa-0006m9-TQ; Sun, 11 Jul 2021 16:56:00 -0400 Received: from mout.web.de ([212.227.17.12]:59665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2gUY-00053v-SW; Sun, 11 Jul 2021 16:56:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1626036941; bh=ikFKBxZwuVui/xeXu4jY/i2f7WYEAP07Id2PEgRa7iI=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject; b=OqqvczHD/RphHrg/Vw/3+vU/HfEgbkAn5IdlmkvA+BUvZEqatG2pe6B91c+0LmKZq gpgv0Z+BfL9sl8EmNFKYyvE1jB4K517QcBmH09/lTgAmdtTbtc0pJozXWSjdAb42hc sJea64vnZxDWbKicxXoM2RnJ9Y/XPW8Jh5fuuy9s= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from gecko.fritz.box ([89.247.255.236]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MLPNm-1m28Fz0j9W-000ZxT; Sun, 11 Jul 2021 22:55:41 +0200 Date: Sun, 11 Jul 2021 22:55:31 +0200 From: Lukas Straub To: qemu-devel Subject: [PATCH v4 0/4] replication: Bugfix and properly attach children Message-ID: MIME-Version: 1.0 X-Provags-ID: V03:K1:tnrGeOZJa74zY50W7HeGGBE8C0V+l/+mvvKlqjZC7DWHhJ2qhJL JixOuWBGP3jOdGRlJvn9Tl7+dwyH7uSxZE6QzKW4xsFZ3eQkYQS/9tw2oXhIeXs0l2OjUq1 O5YcViBd78aDWftZls58fpfnBxwky9Mrm5ankZTn+92Dl3L1+cIRLNHSqTqZSwnCcWWDutn Buv5ADkMMfvRMH+OR0Jwg== X-UI-Out-Filterresults: notjunk:1;V03:K0:EBC5UsPze3I=:sdwhrMC0Ypt1+/zm5GHlrb mcdR9hLLA/l8fdN21R2GGDLg11SgV1vp+Ug9qKpjC9rxgb3/0qBIXpRI8X9AIhg4rtI3ccGj1 hQUINRxj1R+6R91Ua/yK35FNrHLqhKVJ0JXL1tIR9cCuZECfQ+ltkEbR+hFyKea237DeS6r8g 3+iwVqZalGU4tWP5XEbOcThZGLKfQwVGdOh/mNxS64E7msnsvUoxfbQXUi9GgoV0AxdF74mtQ mR3drgCr+QfOmlHclvhTyuUxkaXXej+UQzfPHwzJT7jHPNCC72zxxLKKUA4jqadktCEEQ8Zvm XanhNIgdnIh0oWSY3iyBH6jNCQcdk6025M7Acb10A1UkKvHXor28ETnB4XhUyNR80AWX0D/kx QTD+YEkdgkPHJP3bbhT+g80Aesgfol0FN62iXYn2w5BKfle1jOlCL+sYZY/JJWbr1hlGm0rn2 rygb8a+YnQpyU7MhvMVtuhzEPoEakDCoqTksl0W0m/FKv8TtxRB7ngRej6bLHZ1FQ9ZNGrHFR VVac9W+eHBLjohf0//b2sCUsJX9gsCK2tDM/4JWiM3l7ubuzt8M90n5qxgE/LUdTb3RsIqwKx BlrvPYbQ4PIwNfdceyWzGmSrSBEgAC2Zm0HMK5F9heE+KGl5XusBpUaib7/wa4OkFjlMrCSWT Qd102X8U1M4KQt3IC4y3Czx1/kmdclX3h0OknNhTHLLDrO8hUsIp1Gu+jM3feh2ykLSdtxXrJ gC3EWmrN6Ggczs6+GoOUhKSG2jSUXXAIJHKiWcc+uVmMJgiwQu16+jjrx45uEWyRnnYYp16eQ qh8rGB1ZAdWsrhsyswkfdOnUjfUixOi00uRnO1qrlZ2Q0Z4AWOxZZQAgSQtp1j1gwfbtmxu/K mLQLgM+J2OGnnYbYBuOtgV9tNJ1RaalYhQ3VcMBWmx0z3aWAbqF+mrzbCNAbgFq/WUTGz1OBf 2+ts/fCDmYuuTgkD7gsErlUeGqfgcRXHlKP3ybPSsi30IX/nVMYbCfbKvqbGjeCBnRwk7WUXw mtFcU1w48pXk37uFAiQfJs9a0G1ubx8jfY01FU3pM6tcRmmeeVLT19exIv3EtGmQi+nrnjomi b/fjlvJJ9vThWee5Eu9RfDcsTunfBstNrLB Received-SPF: pass client-ip=212.227.17.12; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block , Wen Congyang , Xie Changlong , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hello Everyone, A while ago Kevin noticed that the replication driver doesn't properly attach the children it wants to use. Instead, it directly copies the BdrvChilds from it's backing file, which is wrong. Ths Patchset fixes the problem, fixes a potential crash in replication_co_writev due to missing permissions and removes a workaround that was put in place back then. Regards, Lukas Straub Changes: -v4: -minor style fixes -clarify why children areguaranteed to be writable in "replication: Remove workaround" -Added Reviewed-by tags -v3: -Split up into multiple patches -Remove s->active_disk -Clarify child permissions in commit message -v2: Test for BDRV_CHILD_PRIMARY in replication_child_perm, since bs->file might not be set yet. (Vladimir) Lukas Straub (4): replication: Remove s->active_disk replication: Reduce usage of s->hidden_disk and s->secondary_disk replication: Properly attach children replication: Remove workaround block/replication.c | 111 +++++++++++++++++++++++++++----------------- 1 file changed, 68 insertions(+), 43 deletions(-) --- 2.20.1