From patchwork Tue Jan 25 13:33:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: BALATON Zoltan X-Patchwork-Id: 12723946 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC210C433EF for ; Tue, 25 Jan 2022 15:19:40 +0000 (UTC) Received: from localhost ([::1]:56994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCNbg-0001IV-2x for qemu-devel@archiver.kernel.org; Tue, 25 Jan 2022 10:19:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCM5o-0006Sp-3D for qemu-devel@nongnu.org; Tue, 25 Jan 2022 08:42:40 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:53379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCM5j-0000HA-1w for qemu-devel@nongnu.org; Tue, 25 Jan 2022 08:42:39 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 6D41F746368; Tue, 25 Jan 2022 14:42:25 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 4C4907456E3; Tue, 25 Jan 2022 14:42:18 +0100 (CET) Message-Id: From: BALATON Zoltan Subject: [PATCH v2 0/5] Misc OHCI clean ups Date: Tue, 25 Jan 2022 14:33:20 +0100 MIME-Version: 1.0 To: qemu-devel@nongnu.org Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v2 - Fixed checkpatch errors Hello, I have these patches from last October when we've looked at what causes problems with mac99 and USB. We've found the main problem is likely not allowing pending packets per endpoint which we did not fix but these patches came out of debugging that and trying to improve the device model so eventually the real problem could be fixed more easily. So these are just clean ups and fixing one potential issue with isochronous transfers breaking pending async packet but it does not solve all problems OHCI currently has. I'm sending it anyway as I don't plan to work further on this so this series could be taken as is for now. Regards, BALATON Zoltan (5): usb/ohci: Move trace point and log ep number to help debugging usb/ohci: Move cancelling async packet to ohci_stop_endpoints() usb/ohci: Move USBPortOps related functions together usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach() usb/ohci: Don't use packet from OHCIState for isochronous transfers hw/usb/hcd-ohci.c | 297 +++++++++++++++++++++----------------------- hw/usb/trace-events | 2 +- 2 files changed, 146 insertions(+), 153 deletions(-)