mbox series

[v2,0/2] vhost-user-test: Add negotiated features check

Message ID cover.1700319559.git.yong.huang@smartx.com (mailing list archive)
Headers show
Series vhost-user-test: Add negotiated features check | expand

Message

Yong Huang Nov. 18, 2023, 3:22 p.m. UTC 
Markus made suggestions for the changes to version 2, and thanks
for that as well.

v2:
- rebase on master.
- drop the "show-bits" option. 
- refine the comment.


v1:
The patchset "Fix the virtio features negotiation flaw" fix a
vhost-user negotiation flaw:
c9bdc449f9 vhost-user: Fix the virtio features negotiation flaw
bebcac052a vhost-user: Refactor the chr_closed_bh
937b7d96e4 vhost-user: Refactor vhost acked features saving

While the test case remain unmerged, the detail reference:
https://lore.kernel.org/qemu-devel/cover.1667232396.git.huangy81@chinatelecom.cn/

Since Michael pointed out that the info virtio makes sense to query
the negotiation feature, this patchset uses the x-query-virtio-status
to retrieve the features instead of exporting netdev capabilities and
information as we did in the previous patchset to aid in confirming
the negotiation's validity.

To do that, we first introduce an "show-bits" argument for
x-query-virtio-status such that the feature bits can be used
directly, and then implement the test case for negotiated features
check. As we post, the code is divided into two patches.

Please review, thanks,
Yong

Hyman Huang (2):
  qapi/virtio: Add feature and status bits for x-query-virtio-status
  vhost-user-test: Add negotiated features check

 hw/virtio/virtio-qmp.c        |   8 +++
 qapi/virtio.json              |  37 +++++++++++++
 tests/qtest/vhost-user-test.c | 100 ++++++++++++++++++++++++++++++++++
 3 files changed, 145 insertions(+)