mbox series

[v2,0/3] Fix resource freeing bugs in virtio-gpu-rutabaga

Message ID cover.1706542958.git.manos.pitsidianakis@linaro.org (mailing list archive)
Headers show
Series Fix resource freeing bugs in virtio-gpu-rutabaga | expand

Message

Manos Pitsidianakis Jan. 29, 2024, 3:45 p.m. UTC
While testing the rutabaga gpu device, we noticed that if the device is
reset, it stops working and complains about missing resource ids. A
quick investigation discovered that the generic VirtIOGPU implementation
frees all resources, but for Rutabaga, they are tied with rutabaga
objects that need to be destroyed as well.

This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.

v1 -> v2 differences:
- addressed review comments re: using the Error API for the
  resource_destroy method.

Manos Pitsidianakis (3):
  hw/display/virtio-gpu.c: use reset_bh class method
  virtio-gpu.c: add resource_destroy class method
  virtio-gpu-rutabaga.c: override resource_destroy method

 include/hw/virtio/virtio-gpu.h   |  3 ++
 hw/display/virtio-gpu-rutabaga.c | 51 ++++++++++++++++++++++++--------
 hw/display/virtio-gpu.c          | 27 ++++++++++++++---
 3 files changed, 65 insertions(+), 16 deletions(-)


base-commit: 7a1dc45af581d2b643cdbf33c01fd96271616fbd