[0/2] pcie: Add simple ACS "support" to the generic PCIe root port

Message

Knut Omang Jan. 23, 2019, 6:27 p.m. UTC

These two patches together implements a PCIe capability
config space header for Access Control Services (ACS) for the
new Qemu specific generic root port. ACS support in the
associated root port is a prerequisite to be able to pass the a function of
the device populating the port through to an L2 guest from an unmodified kernel.
Without this, the IOMMU group the device belongs to will also
include the root port itself, and all functions the device provides.

With an SR/IOV device this becomes even more important, as the whole
purpose with SR/IOV is to be able to share out individual VFs to different
guests, which will not be permitted by VFIO or the Windows Hyper-V equivalent
unless ACS is supported by the root port.

These patches can also be found as part of an updated version of
my SR/IOV emulation patch set at

  https://github.com/knuto/qemu/tree/sriov_patches_v9

Knut Omang (2):
  pcie: Add a simple PCIe ACS (Access Control Services) helper function
  gen_pcie_root_port: Add ACS (Access Control Services) capability

 hw/pci-bridge/gen_pcie_root_port.c |  2 ++
 hw/pci-bridge/ioh3420.c            |  1 -
 hw/pci-bridge/pcie_root_port.c     |  3 +++
 hw/pci/pcie.c                      | 14 ++++++++++++++
 include/hw/pci/pcie.h              |  1 +
 include/hw/pci/pcie_port.h         |  1 +
 include/hw/pci/pcie_regs.h         |  4 ++++
 7 files changed, 25 insertions(+), 1 deletion(-)

base-commit: a8d2b0685681e2f291faaa501efbbd76875f8ec8

Comments

[e-mail] Jan. 31, 2019, 5:49 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/cover.c7f64d9a8[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/2] pcie: Add simple ACS "support" to the generic PCIe root port
Type: series
Message-id: cover.c7f64d9a8[e-mail]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d758b99be0 gen_pcie_root_port: Add ACS (Access Control Services) capability
f09b14c145 pcie: Add a simple PCIe ACS (Access Control Services) helper function

=== OUTPUT BEGIN ===
1/2 Checking commit f09b14c145d7 (pcie: Add a simple PCIe ACS (Access Control Services) helper function)
WARNING: line over 80 characters
#30: FILE: hw/pci/pcie.c:917:
+                 PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF);

WARNING: line over 80 characters
#32: FILE: hw/pci/pcie.c:919:
+                 PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | PCI_ACS_CR | PCI_ACS_UF);

ERROR: code indent should never use tabs
#57: FILE: include/hw/pci/pcie_regs.h:179:
+#define PCI_ACS_VER^I^I^I0x2$

total: 1 errors, 2 warnings, 32 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit d758b99be0f8 (gen_pcie_root_port: Add ACS (Access Control Services) capability)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.c7f64d9a8[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]