From patchwork Tue Feb 7 06:54:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 9559277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD3A860434 for ; Tue, 7 Feb 2017 06:55:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDE4120007 for ; Tue, 7 Feb 2017 06:55:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C23AB27CEA; Tue, 7 Feb 2017 06:55:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4E8D020007 for ; Tue, 7 Feb 2017 06:55:16 +0000 (UTC) Received: from localhost ([::1]:52330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cazgJ-0003NO-Ek for patchwork-qemu-devel@patchwork.kernel.org; Tue, 07 Feb 2017 01:55:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cazg3-0003N6-TV for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cazg0-0002xy-T5 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:55:00 -0500 Received: from mail.ispras.ru ([83.149.199.45]:40782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cazg0-0002xo-LW for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:54:56 -0500 Received: from PASHAISP (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id DADCF540068; Tue, 7 Feb 2017 09:54:55 +0300 (MSK) From: "Pavel Dovgalyuk" To: Date: Tue, 7 Feb 2017 09:54:57 +0300 Message-ID: <002801d2810f$18809c20$4981d460$@ru> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdKBDxhR3PDiSpR/Ti6OwBTII4ainw== Content-Language: ru X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [PATCH] icount: remove useless exit_request assignment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Paolo Bonzini' , 'Pavel Dovgalyuk' Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch removes unneeded assignment to cpu->exit_request. cpu_exec_nocache executes all available instructions and therefore icount becomes 0. Then other conditions will break the execution loop, making assignment to cpu->exit_request useless. This patch should be applied over Paolo's series: https://www.mail-archive.com/qemu-devel@nongnu.org/msg426058.html Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cpu-exec.c b/cpu-exec.c index 5cef8bc..91d1faf 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -577,7 +577,6 @@ static inline void cpu_loop_exec_tb(CPUState *cpu, TranslationBlock *tb, if (insns_left > 0) { cpu_exec_nocache(cpu, insns_left, tb, false); } - atomic_set(&cpu->exit_request, 1); } }