From patchwork Thu Feb 22 21:55:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 10236457 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4AD1B602DC for ; Thu, 22 Feb 2018 21:56:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41B4128F75 for ; Thu, 22 Feb 2018 21:56:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 362C528F89; Thu, 22 Feb 2018 21:56:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F93128F75 for ; Thu, 22 Feb 2018 21:56:17 +0000 (UTC) Received: from localhost ([::1]:41046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoyqd-0000Pr-2p for patchwork-qemu-devel@patchwork.kernel.org; Thu, 22 Feb 2018 16:56:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoypk-0008M5-RQ for qemu-devel@nongnu.org; Thu, 22 Feb 2018 16:55:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoypj-00033T-Tt for qemu-devel@nongnu.org; Thu, 22 Feb 2018 16:55:20 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33692 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eoypf-00031i-AN; Thu, 22 Feb 2018 16:55:15 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2530840201A1; Thu, 22 Feb 2018 21:55:07 +0000 (UTC) Received: from [10.10.122.122] (ovpn-122-122.rdu2.redhat.com [10.10.122.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C4252024CA9; Thu, 22 Feb 2018 21:55:00 +0000 (UTC) To: Peter Maydell , QEMU Developers References: <20180220180325.29818-1-peter.maydell@linaro.org> <151932620203.726.14470172414364772802@bdbb90650ae5> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <12157307-d058-ba0d-affd-779a92981928@redhat.com> Date: Thu, 22 Feb 2018 15:55:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 22 Feb 2018 21:55:07 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 22 Feb 2018 21:55:07 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'eblake@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm , Fam Zheng , "patches@linaro.org" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 02/22/2018 01:11 PM, Peter Maydell wrote: >> ERROR: line over 90 characters >> #54: FILE: hw/arm/mps2-tz.c:21: >> + * https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/mps2 >> > Does anybody better with perl and more familiar with checkpatch's > internals feel like tweaking it to suppress the over-long-line > complaint for URLs ? This one-liner appears to do the trick; I'll submit it formally in another thread: diff --git i/scripts/checkpatch.pl w/scripts/checkpatch.pl index 1b4b812e28f..0d3f753c665 100755 --- i/scripts/checkpatch.pl +++ w/scripts/checkpatch.pl @@ -1447,9 +1447,10 @@ sub process { # check we are in a valid source file if not then ignore this hunk next if ($realfile !~ /$SrcFile/); -#90 column limit +#90 column limit; exempt URLs, if no other words on line if ($line =~ /^\+/ && !($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) && + !($rawline =~ /^[^[:alnum:]]*https?:\S*$/) && $length > 80) { if ($length > 90) {