From patchwork Thu Jan 21 01:37:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 8076521 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3B2099F1C0 for ; Thu, 21 Jan 2016 01:37:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 918212054A for ; Thu, 21 Jan 2016 01:37:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17BDA20212 for ; Thu, 21 Jan 2016 01:37:16 +0000 (UTC) Received: from localhost ([::1]:45704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM4BX-0004E7-89 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 20 Jan 2016 20:37:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM4BM-0004Dh-N9 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 20:37:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM4BJ-0002H3-Gh for qemu-devel@nongnu.org; Wed, 20 Jan 2016 20:37:04 -0500 Received: from ozlabs.org ([103.22.144.67]:44411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM4BJ-0002Fc-6g; Wed, 20 Jan 2016 20:37:01 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 2DB32140BD3; Thu, 21 Jan 2016 12:36:58 +1100 (AEDT) From: David Gibson To: imammedo@redhat.com, pbonzini@redhat.com, ehabkost@redhat.com Date: Thu, 21 Jan 2016 12:37:51 +1100 Message-Id: <1453340271-7417-1-git-send-email-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.5.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 103.22.144.67 Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH] dimm: Correct type of MemoryHotplugState->base X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'base' field of MemoryHotplugState is ram_addr_t, which indicates that it exists in the abstract address space of RAM regions. However, the actual usage of this field indicates that it is a concrete physical address (it's passed as an offset to memory_region_add_subgregion for example). So, correct its type to 'hwaddr'. Signed-off-by: David Gibson Reviewed-by: Igor Mammedov Acked-by: Eduardo Habkost --- include/hw/mem/pc-dimm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h index d83bf30..218dfb0 100644 --- a/include/hw/mem/pc-dimm.h +++ b/include/hw/mem/pc-dimm.h @@ -77,7 +77,7 @@ typedef struct PCDIMMDeviceClass { * @mr: hotplug memory address space container */ typedef struct MemoryHotplugState { - ram_addr_t base; + hwaddr base; MemoryRegion mr; } MemoryHotplugState;