From patchwork Mon Jan 25 16:49:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 8112331 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4ACEBBEEED for ; Mon, 25 Jan 2016 16:50:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7E242025A for ; Mon, 25 Jan 2016 16:50:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F7D202E9 for ; Mon, 25 Jan 2016 16:50:24 +0000 (UTC) Received: from localhost ([::1]:39640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNkLP-0008VJ-If for patchwork-qemu-devel@patchwork.kernel.org; Mon, 25 Jan 2016 11:50:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNkKj-0007VJ-Jf for qemu-devel@nongnu.org; Mon, 25 Jan 2016 11:49:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNkKf-0005eQ-Ob for qemu-devel@nongnu.org; Mon, 25 Jan 2016 11:49:41 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:34801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNkKf-0005eB-FA for qemu-devel@nongnu.org; Mon, 25 Jan 2016 11:49:37 -0500 Received: by mail-wm0-x230.google.com with SMTP id u188so73696664wmu.1 for ; Mon, 25 Jan 2016 08:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=iT+orQTi2ofNGbuJUklgRB0ZkBvb+YfuvGDcmgFO5Z8=; b=Y0W+HdzY6htiRnzsAjmI575SC0AT8boWVSdPoS0yh8zpmMIpCSf5+Efy8NRmU284xx 8gWswzxqsJ1KRgtWt4zcjG7z7oFnzOj3wh0k8Sr1WjkKtZjODg6EohCcOHu1P1P9DxM0 WgxR9tvhvpxOTVeNyef5MEupeyBgAv4jCqSjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=iT+orQTi2ofNGbuJUklgRB0ZkBvb+YfuvGDcmgFO5Z8=; b=aTJX/ZK7RaoSsvh7lmeol2SR5WGq9H1YBThnAHazHFWWHtPpCm2eqq2u2i/Cko1LDD tv03Rfj1BGfaXrw4TaVoS/JU806uzfnhOItK1nZY045JN3kszxRdhomYWtkm+raC4bbu I5O5pLjt8xTU6YfJtBVf24O0O9RqAG1ktMyOPAQKiLXgRI2kSKGZY7vi/U6PCF5JpWXB 9glf43BwucuwMuD2uBE4WtgSYgV0i1LOALY4FE41SprYiPQWoc5WgUy3BPIftefxJSDs Ax3+NlrY5AKQRIQyhkdWTqd5vyqK8S+TFoz5v+1McvahH+hXSrVR2Mo1kVmcOTBfSjVX zGNA== X-Gm-Message-State: AG10YOR681Z++KofC1lJv49AbqcNIWcrAHTXq4NzqSIBAmGdyVfT1PpbzswwU6sqSFRVRzOt X-Received: by 10.194.175.233 with SMTP id cd9mr18902724wjc.115.1453740576723; Mon, 25 Jan 2016 08:49:36 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w17sm16954800wmw.15.2016.01.25.08.49.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jan 2016 08:49:34 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id ABB363E10FA; Mon, 25 Jan 2016 16:49:33 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Mon, 25 Jan 2016 16:49:15 +0000 Message-Id: <1453740558-16303-2-git-send-email-alex.bennee@linaro.org> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453740558-16303-1-git-send-email-alex.bennee@linaro.org> References: <1453740558-16303-1-git-send-email-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::230 Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , fred.konrad@greensocs.com Subject: [Qemu-devel] [RFC PATCH 1/4] configure: move EXTRA_CFLAGS append to the end X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When using --extra-cflags to override defaults the flags need to be set at the end lest they be reset by later options. This affects optimisation as well where "-O0 .. -O3" will just takes the most recent option. We also set CFLAGS so the options are passed to other built binaries. Signed-off-by: Alex Bennée --- configure | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 44ac9ab..7d23c6c 100755 --- a/configure +++ b/configure @@ -360,8 +360,7 @@ for opt do ;; --cpu=*) cpu="$optarg" ;; - --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg" - EXTRA_CFLAGS="$optarg" + --extra-cflags=*) EXTRA_CFLAGS="$optarg" ;; --extra-ldflags=*) LDFLAGS="$LDFLAGS $optarg" EXTRA_LDFLAGS="$optarg" @@ -4715,6 +4714,10 @@ fi QEMU_CFLAGS="$pixman_cflags $fdt_cflags $QEMU_CFLAGS" libs_softmmu="$pixman_libs $libs_softmmu" +# Now it the time to append extra-cflags +CFLAGS="$CFLAGS $EXTRA_CFLAGS" +QEMU_CFLAGS="$QEMU_CFLAGS $EXTRA_CFLAGS" + echo "Install prefix $prefix" echo "BIOS directory `eval echo $qemu_datadir`" echo "binary directory `eval echo $bindir`"