From patchwork Tue Jan 26 13:46:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8122531 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 92A64BEEE5 for ; Tue, 26 Jan 2016 13:51:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D955020256 for ; Tue, 26 Jan 2016 13:51:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEC8520254 for ; Tue, 26 Jan 2016 13:51:47 +0000 (UTC) Received: from localhost ([::1]:43950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO427-0007j7-CZ for patchwork-qemu-devel@patchwork.kernel.org; Tue, 26 Jan 2016 08:51:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO3yL-0008Ln-RB for qemu-devel@nongnu.org; Tue, 26 Jan 2016 08:47:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO3yJ-00042k-4b for qemu-devel@nongnu.org; Tue, 26 Jan 2016 08:47:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO3yI-00042d-Su for qemu-devel@nongnu.org; Tue, 26 Jan 2016 08:47:51 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 7E2318F861; Tue, 26 Jan 2016 13:47:50 +0000 (UTC) Received: from 640k.localdomain.com (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0QDlNqR028272; Tue, 26 Jan 2016 08:47:49 -0500 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 26 Jan 2016 14:46:48 +0100 Message-Id: <1453816041-36362-17-git-send-email-pbonzini@redhat.com> In-Reply-To: <1453816041-36362-1-git-send-email-pbonzini@redhat.com> References: <1453816041-36362-1-git-send-email-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Janosch Frank Subject: [Qemu-devel] [PULL 16/49] scripts/kvm/kvm_stat: Fix spaces around keyword assignments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Janosch Frank Keyword assignments should not not have spaces around the equal character according to PEP8. Reviewed-by: Jason J. Herne Signed-off-by: Janosch Frank Message-Id: <1452525484-32309-11-git-send-email-frankja@linux.vnet.ibm.com> Signed-off-by: Paolo Bonzini --- scripts/kvm/kvm_stat | 62 ++++++++++++++++++++++++++-------------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 9f943ef..b1e5853 100755 --- a/scripts/kvm/kvm_stat +++ b/scripts/kvm/kvm_stat @@ -333,10 +333,10 @@ class Group(object): self.events = [] self.group_leader = None self.cpu = cpu - def add_event(self, name, event_set, tracepoint, filter = None): - self.events.append(Event(group = self, - name = name, event_set = event_set, - tracepoint = tracepoint, filter = filter)) + def add_event(self, name, event_set, tracepoint, filter=None): + self.events.append(Event(group=self, + name=name, event_set=event_set, + tracepoint=tracepoint, filter=filter)) if len(self.events) == 1: self.file = os.fdopen(self.events[0].fd) def read(self): @@ -346,7 +346,7 @@ class Group(object): struct.unpack(fmt, self.file.read(bytes)))) class Event(object): - def __init__(self, group, name, event_set, tracepoint, filter = None): + def __init__(self, group, name, event_set, tracepoint, filter=None): self.name = name attr = perf_event_attr() attr.type = PERF_TYPE_TRACEPOINT @@ -421,9 +421,9 @@ class TracepointProvider(object): tracepoint, sub = m.groups() filter = '%s==%d\0' % (filters[tracepoint][0], filters[tracepoint][1][sub]) - event = group.add_event(name, event_set = 'kvm', - tracepoint = tracepoint, - filter = filter) + event = group.add_event(name, event_set='kvm', + tracepoint=tracepoint, + filter=filter) self.group_leaders.append(group) def select(self, fields): for group in self.group_leaders: @@ -441,7 +441,7 @@ class TracepointProvider(object): return ret class Stats: - def __init__(self, providers, fields = None): + def __init__(self, providers, fields=None): self.providers = providers self.fields_filter = fields self._update() @@ -499,7 +499,7 @@ def tui(screen, stats): return (-s[x][1], -s[x][0]) else: return (0, -s[x][0]) - for key in sorted(s.keys(), key = sortkey): + for key in sorted(s.keys(), key=sortkey): if row >= screen.getmaxyx()[0]: break values = s[key] @@ -563,34 +563,34 @@ def log(stats): def get_options(): optparser = optparse.OptionParser() optparser.add_option('-1', '--once', '--batch', - action = 'store_true', - default = False, - dest = 'once', - help = 'run in batch mode for one second', + action='store_true', + default=False, + dest='once', + help='run in batch mode for one second', ) optparser.add_option('-l', '--log', - action = 'store_true', - default = False, - dest = 'log', - help = 'run in logging mode (like vmstat)', + action='store_true', + default=False, + dest='log', + help='run in logging mode (like vmstat)', ) optparser.add_option('-t', '--tracepoints', - action = 'store_true', - default = False, - dest = 'tracepoints', - help = 'retrieve statistics from tracepoints', + action='store_true', + default=False, + dest='tracepoints', + help='retrieve statistics from tracepoints', ) optparser.add_option('-d', '--debugfs', - action = 'store_true', - default = False, - dest = 'debugfs', - help = 'retrieve statistics from debugfs', + action='store_true', + default=False, + dest='debugfs', + help='retrieve statistics from debugfs', ) optparser.add_option('-f', '--fields', - action = 'store', - default = None, - dest = 'fields', - help = 'fields to display (regex)', + action='store', + default=None, + dest='fields', + help='fields to display (regex)', ) (options, _) = optparser.parse_args(sys.argv) return options @@ -629,7 +629,7 @@ def main(): detect_platform() options = get_options() providers = get_providers(options) - stats = Stats(providers, fields = options.fields) + stats = Stats(providers, fields=options.fields) if options.log: log(stats)