From patchwork Tue Jan 26 16:59:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8124881 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 69F0B9F6DA for ; Tue, 26 Jan 2016 17:00:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D98BA20253 for ; Tue, 26 Jan 2016 17:00:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C43F20149 for ; Tue, 26 Jan 2016 17:00:07 +0000 (UTC) Received: from localhost ([::1]:45102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6yM-0001F5-Jx for patchwork-qemu-devel@patchwork.kernel.org; Tue, 26 Jan 2016 12:00:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6y2-00015R-PB for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO6xz-00008b-Jl for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6xz-00008Q-EV for qemu-devel@nongnu.org; Tue, 26 Jan 2016 11:59:43 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 05E1A263C for ; Tue, 26 Jan 2016 16:59:43 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0QGxfbe003191; Tue, 26 Jan 2016 11:59:41 -0500 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 26 Jan 2016 17:59:40 +0100 Message-Id: <1453827580-29159-1-git-send-email-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: stefanha@redhat.com Subject: [Qemu-devel] [PATCH] memory: add early bail out from cpu_physical_memory_set_dirty_range X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This condition is true in the common case, so we can cut out the body of the function. In addition, this makes it easier for the compiler to do at least partial inlining, even if it decides that fully inlining the function is unreasonable. Signed-off-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi --- include/exec/ram_addr.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index ef1489d..6e31fb5 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -161,6 +161,10 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, unsigned long end, page; unsigned long **d = ram_list.dirty_memory; + if (!mask && !xen_enabled()) { + return; + } + end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; page = start >> TARGET_PAGE_BITS; if (likely(mask & (1 << DIRTY_MEMORY_MIGRATION))) {