diff mbox

[1/2] disas/microblaze.c: Don't define TRUE or FALSE

Message ID 1453831531-667-2-git-send-email-peter.maydell@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Maydell Jan. 26, 2016, 6:05 p.m. UTC 
Don't define TRUE and FALSE locally or manually include stdio.h;
instead use osdep.h which provides them.

This is a necessary prerequisite for moving to "everywhere includes
osdep.h", because otherwise there is a compile error due to the
redefinition of TRUE and FALSE.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 disas/microblaze.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Eric Blake Jan. 26, 2016, 6:44 p.m. UTC | #1 
On 01/26/2016 11:05 AM, Peter Maydell wrote:
> Don't define TRUE and FALSE locally or manually include stdio.h;
> instead use osdep.h which provides them.
> 
> This is a necessary prerequisite for moving to "everywhere includes
> osdep.h", because otherwise there is a compile error due to the
> redefinition of TRUE and FALSE.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  disas/microblaze.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/disas/microblaze.c b/disas/microblaze.c
index 5d15907..91b30ac 100644
--- a/disas/microblaze.c
+++ b/disas/microblaze.c
@@ -33,13 +33,10 @@  along with this program; if not, see <http://www.gnu.org/licenses/>. */
  */
 
 
-#include <stdio.h>
+#include "qemu/osdep.h"
 #define STATIC_TABLE
 #define DEFINE_TABLE
 
-#define TRUE   1
-#define FALSE  0
-
 #ifndef MICROBLAZE_OPC
 #define MICROBLAZE_OPC
 /* Assembler instructions for Xilinx's microblaze processor