From patchwork Tue Jan 26 21:32:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Herv=C3=A9_Poussineau?= X-Patchwork-Id: 8127621 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9A3B49F1CC for ; Tue, 26 Jan 2016 21:33:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C327420221 for ; Tue, 26 Jan 2016 21:32:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B67B820222 for ; Tue, 26 Jan 2016 21:32:58 +0000 (UTC) Received: from localhost ([::1]:46930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOBEQ-0003w7-1E for patchwork-qemu-devel@patchwork.kernel.org; Tue, 26 Jan 2016 16:32:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOBE8-0003sg-DX for qemu-devel@nongnu.org; Tue, 26 Jan 2016 16:32:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOBE6-0006fj-LX for qemu-devel@nongnu.org; Tue, 26 Jan 2016 16:32:40 -0500 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]:8501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOBE6-0006fa-CV for qemu-devel@nongnu.org; Tue, 26 Jan 2016 16:32:38 -0500 Received: from localhost.localdomain (unknown [82.227.227.196]) by smtp2-g21.free.fr (Postfix) with ESMTP id 33ACD4B01C3; Tue, 26 Jan 2016 22:30:43 +0100 (CET) From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= To: qemu-devel@nongnu.org Date: Tue, 26 Jan 2016 22:32:16 +0100 Message-Id: <1453843944-26833-12-git-send-email-hpoussin@reactos.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1453843944-26833-1-git-send-email-hpoussin@reactos.org> References: <1453843944-26833-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 2a01:e0c:1:1599::11 Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , John Snow , "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH v3 11/19] i8257: implement the IsaDma interface X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rewrite the global DMA_*() functions to use the IsaDma interface. Note that these functions will be deleted in a few commits. Signed-off-by: Hervé Poussineau --- hw/dma/i8257.c | 148 +++++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 117 insertions(+), 31 deletions(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 5210e0e..291435d 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -44,8 +44,6 @@ #define ADDR 0 #define COUNT 1 -static I8257State *dma_controllers[2]; - enum { CMD_MEMORY_TO_MEMORY = 0x01, CMD_FIXED_ADDRESS = 0x02, @@ -288,31 +286,36 @@ static uint64_t i8257_read_cont(void *opaque, hwaddr nport, unsigned size) return val; } -int DMA_get_channel_mode (int nchan) +static IsaDmaTransferMode i8257_dma_get_transfer_mode(IsaDma *obj, int nchan) +{ + I8257State *d = I8257(obj); + return (d->regs[nchan & 3].mode >> 2) & 3; +} + +static bool i8257_dma_has_autoinitialization(IsaDma *obj, int nchan) { - return dma_controllers[nchan > 3]->regs[nchan & 3].mode; + I8257State *d = I8257(obj); + return (d->regs[nchan & 3].mode >> 4) & 1; } -void DMA_hold_DREQ (int nchan) +static void i8257_dma_hold_DREQ(IsaDma *obj, int nchan) { - int ncont, ichan; + I8257State *d = I8257(obj); + int ichan; - ncont = nchan > 3; ichan = nchan & 3; - linfo ("held cont=%d chan=%d\n", ncont, ichan); - dma_controllers[ncont]->status |= 1 << (ichan + 4); - i8257_dma_run(dma_controllers[ncont]); + d->status |= 1 << (ichan + 4); + i8257_dma_run(d); } -void DMA_release_DREQ (int nchan) +static void i8257_dma_release_DREQ(IsaDma *obj, int nchan) { - int ncont, ichan; + I8257State *d = I8257(obj); + int ichan; - ncont = nchan > 3; ichan = nchan & 3; - linfo ("released cont=%d chan=%d\n", ncont, ichan); - dma_controllers[ncont]->status &= ~(1 << (ichan + 4)); - i8257_dma_run(dma_controllers[ncont]); + d->status &= ~(1 << (ichan + 4)); + i8257_dma_run(d); } static void i8257_channel_run(I8257State *d, int ichan) @@ -372,24 +375,26 @@ out: } } -void DMA_register_channel (int nchan, - DMA_transfer_handler transfer_handler, - void *opaque) +static void i8257_dma_register_channel(IsaDma *obj, int nchan, + DMA_transfer_handler transfer_handler, + void *opaque) { + I8257State *d = I8257(obj); I8257Regs *r; - int ichan, ncont; + int ichan; - ncont = nchan > 3; ichan = nchan & 3; - r = dma_controllers[ncont]->regs + ichan; + r = d->regs + ichan; r->transfer_handler = transfer_handler; r->opaque = opaque; } -int DMA_read_memory (int nchan, void *buf, int pos, int len) +static int i8257_dma_read_memory(IsaDma *obj, int nchan, void *buf, int pos, + int len) { - I8257Regs *r = &dma_controllers[nchan > 3]->regs[nchan & 3]; + I8257State *d = I8257(obj); + I8257Regs *r = &d->regs[nchan & 3]; hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR]; if (r->mode & 0x20) { @@ -409,9 +414,11 @@ int DMA_read_memory (int nchan, void *buf, int pos, int len) return len; } -int DMA_write_memory (int nchan, void *buf, int pos, int len) +static int i8257_dma_write_memory(IsaDma *obj, int nchan, void *buf, int pos, + int len) { - I8257Regs *r = &dma_controllers[nchan > 3]->regs[nchan & 3]; + I8257State *s = I8257(obj); + I8257Regs *r = &s->regs[nchan & 3]; hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR]; if (r->mode & 0x20) { @@ -434,10 +441,10 @@ int DMA_write_memory (int nchan, void *buf, int pos, int len) /* request the emulator to transfer a new DMA memory block ASAP (even * if the idle bottom half would not have exited the iothread yet). */ -void DMA_schedule(void) +static void i8257_dma_schedule(IsaDma *obj) { - if (dma_controllers[0]->dma_bh_scheduled || - dma_controllers[1]->dma_bh_scheduled) { + I8257State *d = I8257(obj); + if (d->dma_bh_scheduled) { qemu_notify_event(); } } @@ -571,11 +578,85 @@ static Property i8257_properties[] = { static void i8257_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); + IsaDmaClass *idc = ISADMA_CLASS(klass); dc->realize = i8257_realize; dc->reset = i8257_reset; dc->vmsd = &vmstate_i8257; dc->props = i8257_properties; + + idc->get_transfer_mode = i8257_dma_get_transfer_mode; + idc->has_autoinitialization = i8257_dma_has_autoinitialization; + idc->read_memory = i8257_dma_read_memory; + idc->write_memory = i8257_dma_write_memory; + idc->hold_DREQ = i8257_dma_hold_DREQ; + idc->release_DREQ = i8257_dma_release_DREQ; + idc->schedule = i8257_dma_schedule; + idc->register_channel = i8257_dma_register_channel; +} + +static ISABus *i8257_bus; + +int DMA_get_channel_mode(int nchan) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + uint8_t res = 0; + + res |= k->has_autoinitialization(dma, nchan) ? 0 : 0x10; + res |= k->get_transfer_mode(dma, nchan) << 2; + + return res; +} + +int DMA_read_memory(int nchan, void *buf, int pos, int size) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + return k->read_memory(dma, nchan, buf, pos, size); +} + +int DMA_write_memory(int nchan, void *buf, int pos, int size) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + return k->write_memory(dma, nchan, buf, pos, size); +} + +void DMA_hold_DREQ(int nchan) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + k->hold_DREQ(dma, nchan); +} + +void DMA_release_DREQ(int nchan) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + k->release_DREQ(dma, nchan); +} + +void DMA_schedule(void) +{ + IsaDma *dma; + IsaDmaClass *k; + int i; + + for (i = 0; i < 2; i++) { + dma = isa_get_dma(i8257_bus, i << 2); + k = ISADMA_GET_CLASS(dma); + k->schedule(dma); + } +} + +void DMA_register_channel(int nchan, + DMA_transfer_handler transfer_handler, + void *opaque) +{ + IsaDma *dma = isa_get_dma(i8257_bus, nchan); + IsaDmaClass *k = ISADMA_GET_CLASS(dma); + k->register_channel(dma, nchan, transfer_handler, opaque); } static const TypeInfo i8257_info = { @@ -583,6 +664,10 @@ static const TypeInfo i8257_info = { .parent = TYPE_ISA_DEVICE, .instance_size = sizeof(I8257State), .class_init = i8257_class_init, + .interfaces = (InterfaceInfo[]) { + { TYPE_ISADMA }, + { } + } }; static void i8257_register_types(void) @@ -604,7 +689,6 @@ void DMA_init(ISABus *bus, int high_page_enable) qdev_prop_set_int32(d, "pageh-base", high_page_enable ? 0x480 : -1); qdev_prop_set_int32(d, "dshift", 0); qdev_init_nofail(d); - dma_controllers[0] = I8257(d); isa2 = isa_create(bus, TYPE_I8257); d = DEVICE(isa2); @@ -613,5 +697,7 @@ void DMA_init(ISABus *bus, int high_page_enable) qdev_prop_set_int32(d, "pageh-base", high_page_enable ? 0x488 : -1); qdev_prop_set_int32(d, "dshift", 1); qdev_init_nofail(d); - dma_controllers[1] = I8257(d); + + isa_bus_dma(bus, ISADMA(isa1), ISADMA(isa2)); + i8257_bus = bus; }