diff mbox

jobs: remove unused structure

Message ID 1454365097-18314-1-git-send-email-jsnow@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

John Snow Feb. 1, 2016, 10:18 p.m. UTC 
Signed-off-by: John Snow <jsnow@redhat.com>
---
 blockjob.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Eric Blake Feb. 1, 2016, 10:21 p.m. UTC | #1 
On 02/01/2016 03:18 PM, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  blockjob.c | 8 --------
>  1 file changed, 8 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/blockjob.c b/blockjob.c
> index 80adb9d..a692142 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
>      }
>  }
>  
> -struct BlockFinishData {
> -    BlockJob *job;
> -    BlockCompletionFunc *cb;
> -    void *opaque;
> -    bool cancelled;
> -    int ret;
> -};
> -
>  static int block_job_finish_sync(BlockJob *job,
>                                   void (*finish)(BlockJob *, Error **errp),
>                                   Error **errp)
>
Fam Zheng Feb. 2, 2016, 2:19 a.m. UTC | #2 
On Mon, 02/01 17:18, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  blockjob.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/blockjob.c b/blockjob.c
> index 80adb9d..a692142 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job)
>      }
>  }
>  
> -struct BlockFinishData {
> -    BlockJob *job;
> -    BlockCompletionFunc *cb;
> -    void *opaque;
> -    bool cancelled;
> -    int ret;
> -};
> -

Duplicates this:

https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg05529.html

Fam

>  static int block_job_finish_sync(BlockJob *job,
>                                   void (*finish)(BlockJob *, Error **errp),
>                                   Error **errp)
> -- 
> 2.4.3
> 
>
diff mbox

Patch

diff --git a/blockjob.c b/blockjob.c
index 80adb9d..a692142 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -278,14 +278,6 @@  void block_job_iostatus_reset(BlockJob *job)
     }
 }
 
-struct BlockFinishData {
-    BlockJob *job;
-    BlockCompletionFunc *cb;
-    void *opaque;
-    bool cancelled;
-    int ret;
-};
-
 static int block_job_finish_sync(BlockJob *job,
                                  void (*finish)(BlockJob *, Error **errp),
                                  Error **errp)