diff mbox

[1/2] m68k: Fix opcode mask for fbcc instruction

Message ID 1454492221-30625-2-git-send-email-glaubitz@physik.fu-berlin.de (mailing list archive)
State New, archived
Headers show

Commit Message

John Paul Adrian Glaubitz Feb. 3, 2016, 9:37 a.m. UTC
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
 target-m68k/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Vivier Feb. 3, 2016, 9:38 a.m. UTC | #1
Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit :
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
>  target-m68k/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 342c040..535d7f9 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2940,7 +2940,7 @@ void register_m68k_insns (CPUM68KState *env)
>      INSN(shift_reg, e0a0, f0f0, CF_ISA_A);
>      INSN(undef_fpu, f000, f000, CF_ISA_A);
>      INSN(fpu,       f200, ffc0, CF_FPU);
> -    INSN(fbcc,      f280, ffc0, CF_FPU);
> +    INSN(fbcc,      f280, ff80, CF_FPU);
>      INSN(frestore,  f340, ffc0, CF_FPU);
>      INSN(fsave,     f340, ffc0, CF_FPU);
>      INSN(intouch,   f340, ffc0, CF_ISA_A);
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
John Paul Adrian Glaubitz Feb. 3, 2016, 9:40 a.m. UTC | #2
Strange. There should be a cover letter coming along as well which
explains my changes. Did you get it?

On 02/03/2016 10:37 AM, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
>  target-m68k/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 342c040..535d7f9 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2940,7 +2940,7 @@ void register_m68k_insns (CPUM68KState *env)
>      INSN(shift_reg, e0a0, f0f0, CF_ISA_A);
>      INSN(undef_fpu, f000, f000, CF_ISA_A);
>      INSN(fpu,       f200, ffc0, CF_FPU);
> -    INSN(fbcc,      f280, ffc0, CF_FPU);
> +    INSN(fbcc,      f280, ff80, CF_FPU);
>      INSN(frestore,  f340, ffc0, CF_FPU);
>      INSN(fsave,     f340, ffc0, CF_FPU);
>      INSN(intouch,   f340, ffc0, CF_ISA_A);
>
Laurent Vivier Feb. 3, 2016, 9:42 a.m. UTC | #3
Le 03/02/2016 10:40, John Paul Adrian Glaubitz a écrit :
> Strange. There should be a cover letter coming along as well which
> explains my changes. Did you get it?

We have the cover letter, but it is never sent to the sender :)

Laurent
> 
> On 02/03/2016 10:37 AM, John Paul Adrian Glaubitz wrote:
>> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> ---
>>  target-m68k/translate.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
>> index 342c040..535d7f9 100644
>> --- a/target-m68k/translate.c
>> +++ b/target-m68k/translate.c
>> @@ -2940,7 +2940,7 @@ void register_m68k_insns (CPUM68KState *env)
>>      INSN(shift_reg, e0a0, f0f0, CF_ISA_A);
>>      INSN(undef_fpu, f000, f000, CF_ISA_A);
>>      INSN(fpu,       f200, ffc0, CF_FPU);
>> -    INSN(fbcc,      f280, ffc0, CF_FPU);
>> +    INSN(fbcc,      f280, ff80, CF_FPU);
>>      INSN(frestore,  f340, ffc0, CF_FPU);
>>      INSN(fsave,     f340, ffc0, CF_FPU);
>>      INSN(intouch,   f340, ffc0, CF_ISA_A);
>>
> 
>
John Paul Adrian Glaubitz Feb. 8, 2016, 11:13 p.m. UTC | #4
On 02/03/2016 10:38 AM, Laurent Vivier wrote:
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Any chance to get this merged quickly?
diff mbox

Patch

diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index 342c040..535d7f9 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -2940,7 +2940,7 @@  void register_m68k_insns (CPUM68KState *env)
     INSN(shift_reg, e0a0, f0f0, CF_ISA_A);
     INSN(undef_fpu, f000, f000, CF_ISA_A);
     INSN(fpu,       f200, ffc0, CF_FPU);
-    INSN(fbcc,      f280, ffc0, CF_FPU);
+    INSN(fbcc,      f280, ff80, CF_FPU);
     INSN(frestore,  f340, ffc0, CF_FPU);
     INSN(fsave,     f340, ffc0, CF_FPU);
     INSN(intouch,   f340, ffc0, CF_ISA_A);