diff mbox

linux-user: set ppc64/ppc64le default CPU to POWER8

Message ID 1454612161-24396-1-git-send-email-lvivier@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laurent Vivier Feb. 4, 2016, 6:56 p.m. UTC
Set the default to the latest CPU version to have the
largest set of available features.

It is also really needed in little-endian mode because
POWER7 is not really supported in this mode and some distros
(at least debian) generate POWER8 code for their ppc64le target.

Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 linux-user/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Graf Feb. 4, 2016, 7:01 p.m. UTC | #1
On 02/04/2016 07:56 PM, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Makes a lot of sense.

Reviewed-by: Alexander Graf <agraf@suse.de>


Alex
Michael Tokarev Feb. 4, 2016, 9:24 p.m. UTC | #2
04.02.2016 21:56, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
> 
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
> 
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Thank you!

/mjt

> ---
>  linux-user/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index e719a2d..2a692e0 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4160,7 +4160,7 @@ int main(int argc, char **argv, char **envp)
>          cpu_model = "or1200";
>  #elif defined(TARGET_PPC)
>  # ifdef TARGET_PPC64
> -        cpu_model = "POWER7";
> +        cpu_model = "POWER8";
>  # else
>          cpu_model = "750";
>  # endif
>
Riku Voipio Feb. 15, 2016, 1:15 p.m. UTC | #3
On torstaina 4. helmikuuta 2016 20.56.01 EET, Laurent Vivier wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.

Applied, thanks. 

> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  linux-user/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index e719a2d..2a692e0 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4160,7 +4160,7 @@ int main(int argc, char **argv, char **envp)
>          cpu_model = "or1200";
>  #elif defined(TARGET_PPC)
>  # ifdef TARGET_PPC64
> -        cpu_model = "POWER7";
> +        cpu_model = "POWER8";
>  # else
>          cpu_model = "750";
>  # endif
Peter Maydell Feb. 15, 2016, 1:25 p.m. UTC | #4
On 4 February 2016 at 18:56, Laurent Vivier <lvivier@redhat.com> wrote:
> Set the default to the latest CPU version to have the
> largest set of available features.
>
> It is also really needed in little-endian mode because
> POWER7 is not really supported in this mode and some distros
> (at least debian) generate POWER8 code for their ppc64le target.
>
> Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813698
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

This patch is a good fix, but for the longer term is it possible
on PPC to define an "any" CPU which is the largest possible set
of usable-together userspace features? That would make it easier
for us to avoid this problem in the future for POWER9, POWER10,...

thanks
-- PMM
diff mbox

Patch

diff --git a/linux-user/main.c b/linux-user/main.c
index e719a2d..2a692e0 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -4160,7 +4160,7 @@  int main(int argc, char **argv, char **envp)
         cpu_model = "or1200";
 #elif defined(TARGET_PPC)
 # ifdef TARGET_PPC64
-        cpu_model = "POWER7";
+        cpu_model = "POWER8";
 # else
         cpu_model = "750";
 # endif