From patchwork Mon Feb 8 16:15:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8251871 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 82983BEEE5 for ; Mon, 8 Feb 2016 16:20:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AA27720254 for ; Mon, 8 Feb 2016 16:20:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE59520148 for ; Mon, 8 Feb 2016 16:20:12 +0000 (UTC) Received: from localhost ([::1]:46228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoXr-0004nb-Jx for patchwork-qemu-devel@patchwork.kernel.org; Mon, 08 Feb 2016 11:20:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoTQ-0006P3-2y for qemu-devel@nongnu.org; Mon, 08 Feb 2016 11:15:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSoTN-0002TQ-WD for qemu-devel@nongnu.org; Mon, 08 Feb 2016 11:15:35 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:36168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoTN-0002TE-Mu for qemu-devel@nongnu.org; Mon, 08 Feb 2016 11:15:33 -0500 Received: by mail-wm0-x242.google.com with SMTP id 128so16172059wmz.3 for ; Mon, 08 Feb 2016 08:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=T6BPHch1HzoQpZnCAj7FXK3g6riAk3L65qX9e4u7hfk=; b=yBt2zIsbdiC7Hc8uLXAOB5Sb3nlfFAYiD/VTnTH/HGt3vDfg3mv6z1EFYQfzwEWFCk QDgVS78Hw5agOhb0za4/H3d011uRVJL3AFlmFxwsTD0gNZx3pswp8zgqx3dO673kNzuk 8MU6WE2KuqVRgFyOG+Z9K3D31MQvA1MRSopxk12PAtwOI4mBLiscA2MjRS4b7Wk46vQe JNisvYb7vTcdCoSemJjmR3JQ+u2w4ru85MrM6+O1tyguA9JAwQDPnOok3H2iegtb9WfN JuKSnwHI4uP2AfiW8UWXYY3MiSD1JgMMVQkAw/Trxn9SesSdHpkvCNjdN1kjqewQ+j0l Tazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=T6BPHch1HzoQpZnCAj7FXK3g6riAk3L65qX9e4u7hfk=; b=PoDu8rOlFvMsJajeZ16aUyN5kS0eZVjVMW7TrcxVDPlqgYMiLqVWtVWoxYVe8FYXvV oohMfTjKPw8oy5T+/4Qkv3kq9hLbRV+79RbLXld5T6rMFgs5gz4JAKGGnu1lmlR4IBne XqOKzN4h9HreSSkP0EUZwmbDRahCkbXpJNufVf9oKiuEZHDCOuFMAdWWagM2TAg9WBIb 1iO6aYW170/sAJmfKDS8wVXh5Yl1jn7FwAR/+14qu16GgJw4Uy8RQfKL5Fl7u+fXxPXO vm58rdZVIuYKmrrkdjkgxrypJ/zYRqCZHsHFgciEwEfL+Yea7KCOYydV/h/EzhyYHlNZ s0vA== X-Gm-Message-State: AG10YOTbXKyFkEifboMUtB44NQiWXUDVR394XvQHmS0g4VTn65RRUyVBit2D3RhxMlVt6Q== X-Received: by 10.194.52.8 with SMTP id p8mr27902222wjo.62.1454948133252; Mon, 08 Feb 2016 08:15:33 -0800 (PST) Received: from donizetti.lan (94-39-141-130.adsl-ull.clienti.tiscali.it. [94.39.141.130]) by smtp.gmail.com with ESMTPSA id v2sm13305429wmd.24.2016.02.08.08.15.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Feb 2016 08:15:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 8 Feb 2016 17:15:04 +0100 Message-Id: <1454948107-11844-14-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1454948107-11844-1-git-send-email-pbonzini@redhat.com> References: <1454948107-11844-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::242 Cc: stefanha@redhat.com Subject: [Qemu-devel] [PATCH 13/16] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Paolo Bonzini --- aio-posix.c | 54 ++++++++++++++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index 450da51..cbdc6e4 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -16,7 +16,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "block/block.h" -#include "qemu/queue.h" +#include "qemu/rcu_queue.h" #include "qemu/sockets.h" #ifdef CONFIG_EPOLL #include @@ -213,6 +213,8 @@ void aio_set_fd_handler(AioContext *ctx, bool is_new = false; bool deleted = false; + qemu_lockcnt_lock(&ctx->list_lock); + node = find_aio_handler(ctx, fd); /* Are we deleting the fd handler? */ @@ -220,14 +222,14 @@ void aio_set_fd_handler(AioContext *ctx, if (node) { g_source_remove_poll(&ctx->source, &node->pfd); - /* If the lock is held, just mark the node as deleted */ - if (ctx->walking_handlers) { + /* If aio_poll is in progress, just mark the node as deleted */ + if (qemu_lockcnt_count(&ctx->list_lock)) { node->deleted = 1; node->pfd.revents = 0; } else { /* Otherwise, delete it for real. We can't just mark it as * deleted because deleted nodes are only cleaned up after - * releasing the walking_handlers lock. + * releasing the list_lock. */ QLIST_REMOVE(node, node); deleted = true; @@ -238,7 +240,7 @@ void aio_set_fd_handler(AioContext *ctx, /* Alloc and insert if it's not already there */ node = g_new0(AioHandler, 1); node->pfd.fd = fd; - QLIST_INSERT_HEAD(&ctx->aio_handlers, node, node); + QLIST_INSERT_HEAD_RCU(&ctx->aio_handlers, node, node); g_source_add_poll(&ctx->source, &node->pfd); is_new = true; @@ -254,6 +256,7 @@ void aio_set_fd_handler(AioContext *ctx, } aio_epoll_update(ctx, node, is_new); + qemu_lockcnt_unlock(&ctx->list_lock); aio_notify(ctx); if (deleted) { g_free(node); @@ -277,20 +280,30 @@ bool aio_prepare(AioContext *ctx) bool aio_pending(AioContext *ctx) { AioHandler *node; + bool result = false; - QLIST_FOREACH(node, &ctx->aio_handlers, node) { + /* + * We have to walk very carefully in case aio_set_fd_handler is + * called while we're walking. + */ + qemu_lockcnt_inc(&ctx->list_lock); + + QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { int revents; revents = node->pfd.revents & node->pfd.events; if (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR) && node->io_read) { - return true; + result = true; + break; } if (revents & (G_IO_OUT | G_IO_ERR) && node->io_write) { - return true; + result = true; + break; } } + qemu_lockcnt_dec(&ctx->list_lock); - return false; + return result; } bool aio_dispatch(AioContext *ctx) @@ -311,13 +324,12 @@ bool aio_dispatch(AioContext *ctx) * We have to walk very carefully in case aio_set_fd_handler is * called while we're walking. */ - ctx->walking_handlers++; + qemu_lockcnt_inc(&ctx->list_lock); - QLIST_FOREACH_SAFE(node, &ctx->aio_handlers, node, tmp) { + QLIST_FOREACH_SAFE_RCU(node, &ctx->aio_handlers, node, tmp) { int revents; - revents = node->pfd.revents & node->pfd.events; - node->pfd.revents = 0; + revents = atomic_xchg(&node->pfd.revents, 0) & node->pfd.events; if (!node->deleted && (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) && @@ -337,16 +349,15 @@ bool aio_dispatch(AioContext *ctx) } if (node->deleted) { - ctx->walking_handlers--; - if (!ctx->walking_handlers) { + if (qemu_lockcnt_dec_if_lock(&ctx->list_lock)) { QLIST_REMOVE(node, node); g_free(node); + qemu_lockcnt_inc_and_unlock(&ctx->list_lock); } - ctx->walking_handlers++; } } - ctx->walking_handlers--; + qemu_lockcnt_dec(&ctx->list_lock); /* Run our timers */ progress |= timerlistgroup_run_timers(&ctx->tlg); @@ -421,12 +432,11 @@ bool aio_poll_internal(AioContext *ctx, bool blocking) atomic_add(&ctx->notify_me, 2); } - ctx->walking_handlers++; - + qemu_lockcnt_inc(&ctx->list_lock); assert(npfd == 0); /* fill pollfds */ - QLIST_FOREACH(node, &ctx->aio_handlers, node) { + QLIST_FOREACH_RCU(node, &ctx->aio_handlers, node) { if (!node->deleted && node->pfd.events && !aio_epoll_enabled(ctx) && aio_node_check(ctx, node->is_external)) { @@ -463,12 +473,12 @@ bool aio_poll_internal(AioContext *ctx, bool blocking) /* if we have any readable fds, dispatch event */ if (ret > 0) { for (i = 0; i < npfd; i++) { - nodes[i]->pfd.revents = pollfds[i].revents; + atomic_or(&nodes[i]->pfd.revents, pollfds[i].revents); } } npfd = 0; - ctx->walking_handlers--; + qemu_lockcnt_dec(&ctx->list_lock); /* Run dispatch even if there were no readable fds to run timers */ if (aio_dispatch(ctx)) {