From patchwork Mon Feb 8 17:03:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8252691 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6C0679F1C1 for ; Mon, 8 Feb 2016 17:13:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C25A3203C3 for ; Mon, 8 Feb 2016 17:13:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 313A220107 for ; Mon, 8 Feb 2016 17:13:51 +0000 (UTC) Received: from localhost ([::1]:46935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSpNm-0004Ew-BE for patchwork-qemu-devel@patchwork.kernel.org; Mon, 08 Feb 2016 12:13:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSpEH-000406-C6 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:04:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSpED-0006vQ-IJ for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:04:01 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSpED-0006v2-7M for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:03:57 -0500 Received: by mail-wm0-x22c.google.com with SMTP id g62so125522631wme.0 for ; Mon, 08 Feb 2016 09:03:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=EVh1/r4U2/v3ecQtIacPT1O1y2q3mvOfN+JiQ9O4Mso=; b=a3tVVR1BL0HBTwHWz9Pi5dlJg28fhDh/YU09oExh/QjCwP8/Ek2wmtqYzHHAs4+8ue TgYgkZkm05XrGsHErQMZ8UeWYPyfVpY1qMXTOSFWEaHqqMCj34Vtol8ZRcCGMnzEygGP AlosaiEw70Jkc6CGdlk1OyD5es2M9L2+3ZREA54/eXHjxpZxwtDqmtQrlovwNhHmzjTG X8GuhK7tHwEwd0w03B4UKkZqH+7byoEZ7o7I/1NrzlBDgcZDgBBQV8NsZLvj0y/Si7rc ht1wrJcVyWB8x0EhcxkSDxdeyMTFI5n72VpfbcBDSd4ysT+2KxxRdr9uAIvIXZUIeZOn WHnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=EVh1/r4U2/v3ecQtIacPT1O1y2q3mvOfN+JiQ9O4Mso=; b=OQFBkYP6Xx72DDvkJLGKTdSrd+6UK0qbZaO5aM7uVhV0+QJrtBybkwm/QilL8SJZrM MUBag+PRkeLtSBqA4j1jOPfN4Nm4ZxbiQk5lduzJq/siDcqrpWXChy8S6PznThSSYtDK wEBhsOqzx6rpS1wvBwm6UjLrYOHJGs4+O+AUrn8O2WyNDLqcjEs0lDFDBs7RgyxQ6FzZ nKBTSc6GCESGkwAznoLfggZP+0yXuec7SNYktEcEk/nzr5fYQRar4U1r+QPNhOLQ33+3 jEThAR8NT2XMqySapLth8Miz+tekySDSMqT8nOb+PagZiBP0W7CFHZfXt2E+P0q5ajDP 1M2w== X-Gm-Message-State: AG10YOTzihPcsJVsbkb5JsT5ez+zBrstCexTLzfNMQXxMztAG4iSpxYAUGSl0mKbutuvrA== X-Received: by 10.28.102.68 with SMTP id a65mr33690619wmc.12.1454951036689; Mon, 08 Feb 2016 09:03:56 -0800 (PST) Received: from 640k.lan (94-39-141-130.adsl-ull.clienti.tiscali.it. [94.39.141.130]) by smtp.gmail.com with ESMTPSA id b1sm30651442wjy.0.2016.02.08.09.03.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Feb 2016 09:03:56 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 8 Feb 2016 18:03:17 +0100 Message-Id: <1454950999-64128-27-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1454950999-64128-1-git-send-email-pbonzini@redhat.com> References: <1454950999-64128-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PULL 26/28] ipmi: do not take/drop iothread lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is not necessary and actually causes a hang; it was probably copied and pasted from KVM code, that is one of the very few places that run outside iothread lock. Signed-off-by: Paolo Bonzini --- hw/ipmi/ipmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index dfab272..6adec1e 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -51,9 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, int checkonly) if (checkonly) { return 0; } - qemu_mutex_lock_iothread(); qmp_inject_nmi(NULL); - qemu_mutex_unlock_iothread(); return 0; case IPMI_POWERCYCLE_CHASSIS: