Message ID | 1455609909-10072-4-git-send-email-pbonzini@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56A71C02AA for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 16 Feb 2016 08:07:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B807F20256 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 16 Feb 2016 08:07:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE273202E6 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 16 Feb 2016 08:07:39 +0000 (UTC) Received: from localhost ([::1]:42800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>) id 1aVafb-0007hU-9L for patchwork-qemu-devel@patchwork.kernel.org; Tue, 16 Feb 2016 03:07:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1aVadL-0004wk-IT for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:05:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1aVadK-0004ia-KV for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:05:19 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:33561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>) id 1aVadK-0004iW-E4 for qemu-devel@nongnu.org; Tue, 16 Feb 2016 03:05:18 -0500 Received: by mail-wm0-x22c.google.com with SMTP id g62so179328404wme.0 for <qemu-devel@nongnu.org>; Tue, 16 Feb 2016 00:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=0Od1n4vj2+XK5ZVnJNeUWs24FkzbVif0E/O77kk42JY=; b=LCkClU7iLt0J/sBNNCBeWW2Cnqykq61EFr29bDWkZ2odASNsP3Qp+aDY5XRwzajpJq eGkwWYuldfFtCcM9aatP+GZ+rfkBdqPmmia3a53DMtDATz6wFOY62Y1a3g4ifrEuBF7W lfMtBAZCzrRLaAmHQxE/f1Drono3SKgfPBjzYAGQAUN1dc7Fd8+Jvfc7d/T23+d1rPu2 NC8KlZwwgM18IhYgbXR41OIg69xyci/zF+3zF94o3woK3sexF+6zo4UfiKGMNeEVADDP R6bJqI7ly9JBE5Q9aOMJbGoe7GsSeCv3ZRZwFVQB4tGBEeE/MCt7L5lQZTbyHZgfjLfl Jv8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=0Od1n4vj2+XK5ZVnJNeUWs24FkzbVif0E/O77kk42JY=; b=TSp7z80v/5PHR2VedfUHL+Smzb6w1SzjvC8Ygl5MB/zlhNk9FvuzM78WZdJw/8zBgz h0bCYxDHMG3FLXG2FqfOQrgzZWfT+b+DV4/5xXAQ0lz7mOM6uCAhDsPFTdVYcdG8LHht GRhpQl6NloSN7M8IJj2j8JVJXdtG/udxgQs8UT0A7Bd7bp/7cWKnOmQo0miqbG7N7RIl NTAQsXoHx21Kx7ytdH7MtCAUNuJjSudadOkyBBphViwGuFAM7n7JbfqYYzFs8T7w8rtA wih96ENSYcQxA/CAyRrxDsuHn6P7bhI/GsCAHnA6atLc1Kr0l83vPSHxQ969RcroZWLJ k49A== X-Gm-Message-State: AG10YORwSN0ktO1iSLXlUd0i/nMGSlDVaPMHudinPqryGscyFbEZqyHCEf5LhAfzSIebYQ== X-Received: by 10.28.174.72 with SMTP id x69mr17037781wme.68.1455609917817; Tue, 16 Feb 2016 00:05:17 -0800 (PST) Received: from donizetti.lan (94-39-180-249.adsl-ull.clienti.tiscali.it. [94.39.180.249]) by smtp.gmail.com with ESMTPSA id q129sm19424602wmd.14.2016.02.16.00.05.15 for <qemu-devel@nongnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2016 00:05:15 -0800 (PST) From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Date: Tue, 16 Feb 2016 09:05:09 +0100 Message-Id: <1455609909-10072-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1455609909-10072-1-git-send-email-pbonzini@redhat.com> References: <1455609909-10072-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PATCH 3/3] mptsas: fix wrong formula X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 1ce3226..499c146 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -824,7 +824,7 @@ static uint32_t mptsas_doorbell_read(MPTSASState *s) { uint32_t ret; - ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_SHIFT; + ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_MASK; ret |= s->state; switch (s->doorbell_state) { case DOORBELL_NONE:
MPI_DOORBELL_WHO_INIT_SHIFT is being repeated twice. Reported by Coverity. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/scsi/mptsas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)