diff mbox

Postcopy: Fix sync count in info migrate

Message ID 1456394631-18010-1-git-send-email-dgilbert@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dr. David Alan Gilbert Feb. 25, 2016, 10:03 a.m. UTC 
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

I'd missed the sync count off in the postcopy case.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/migration.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Zhanghailiang Feb. 25, 2016, 10:55 a.m. UTC | #1 
On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> I'd missed the sync count off in the postcopy case.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   migration/migration.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index fc5e50b..34d3e5f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>           info->ram->normal_bytes = norm_mig_bytes_transferred();
>           info->ram->dirty_pages_rate = s->dirty_pages_rate;
>           info->ram->mbps = s->mbps;
> +        info->ram->dirty_sync_count = s->dirty_sync_count;
>
>           if (blk_mig_active()) {
>               info->has_disk = true;
>

Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE'
case. Maybe we can simplify it.
Dr. David Alan Gilbert Feb. 25, 2016, 10:59 a.m. UTC | #2 
* Hailiang Zhang (zhang.zhanghailiang@huawei.com) wrote:
> On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> >I'd missed the sync count off in the postcopy case.
> >
> >Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >---
> >  migration/migration.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/migration/migration.c b/migration/migration.c
> >index fc5e50b..34d3e5f 100644
> >--- a/migration/migration.c
> >+++ b/migration/migration.c
> >@@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> >          info->ram->normal_bytes = norm_mig_bytes_transferred();
> >          info->ram->dirty_pages_rate = s->dirty_pages_rate;
> >          info->ram->mbps = s->mbps;
> >+        info->ram->dirty_sync_count = s->dirty_sync_count;
> >
> >          if (blk_mig_active()) {
> >              info->has_disk = true;
> >
> 
> Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>

Thanks,

> I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE'
> case. Maybe we can simplify it.

Yes, I keep intending to add more stats to POSTCOPY_ACTIVE, but haven't
done so yet.

Dave

> 
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff mbox

Patch

diff --git a/migration/migration.c b/migration/migration.c
index fc5e50b..34d3e5f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -626,6 +626,7 @@  MigrationInfo *qmp_query_migrate(Error **errp)
         info->ram->normal_bytes = norm_mig_bytes_transferred();
         info->ram->dirty_pages_rate = s->dirty_pages_rate;
         info->ram->mbps = s->mbps;
+        info->ram->dirty_sync_count = s->dirty_sync_count;
 
         if (blk_mig_active()) {
             info->has_disk = true;