| Message ID | 1456564857-29160-12-git-send-email-famz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/27/2016 04:20 AM, Fam Zheng wrote: > We use a loop over bs->dirty_bitmaps to make sure the caller is > only releasing a bitmap owned by bs. Let's also assert that in this case > the caller is releasing a bitmap that does exist. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > block/dirty-bitmap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index a0c5acb..27d33e7 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -304,6 +304,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs, > } > } > } > + if (bitmap) { > + abort(); > + } > } > > void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap) > Bad context, but I assume what happens is if we have a bitmap, we have an early return above, so this should be unreachable. Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index a0c5acb..27d33e7 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -304,6 +304,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs, } } } + if (bitmap) { + abort(); + } } void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
We use a loop over bs->dirty_bitmaps to make sure the caller is only releasing a bitmap owned by bs. Let's also assert that in this case the caller is releasing a bitmap that does exist. Signed-off-by: Fam Zheng <famz@redhat.com> --- block/dirty-bitmap.c | 3 +++ 1 file changed, 3 insertions(+)