diff mbox

[v3,12/13] .gitignore: Ignore temporary dockerfile

Message ID 1457086720-30391-13-git-send-email-famz@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fam Zheng March 4, 2016, 10:18 a.m. UTC
Docker build requires a "context" directory and we use the
$QEMU_SRC/tests/docker/ directory, and the temoprary dockerfile has to be in
the context.

docker_build normally cleans up this file but let's add an entry here just in
case it fails to.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Bennée March 11, 2016, 4:14 p.m. UTC | #1
Fam Zheng <famz@redhat.com> writes:

> Docker build requires a "context" directory and we use the
> $QEMU_SRC/tests/docker/ directory, and the temoprary dockerfile has to be in
> the context.
>
> docker_build normally cleans up this file but let's add an entry here just in
> case it fails to.

I think the need for this will go away if you use python's tempfile.

>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 88a80ff..a335b7b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -109,3 +109,4 @@ cscope.*
>  tags
>  TAGS
>  *~
> +/tests/docker/*.docker.tmp


--
Alex Bennée
Fam Zheng March 16, 2016, 6:31 a.m. UTC | #2
On Fri, 03/11 16:14, Alex Bennée wrote:
> 
> Fam Zheng <famz@redhat.com> writes:
> 
> > Docker build requires a "context" directory and we use the
> > $QEMU_SRC/tests/docker/ directory, and the temoprary dockerfile has to be in
> > the context.
> >
> > docker_build normally cleans up this file but let's add an entry here just in
> > case it fails to.
> 
> I think the need for this will go away if you use python's tempfile.

Yes, I'll drop it.

Fam

> 
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 88a80ff..a335b7b 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -109,3 +109,4 @@ cscope.*
> >  tags
> >  TAGS
> >  *~
> > +/tests/docker/*.docker.tmp
> 
> 
> --
> Alex Bennée
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index 88a80ff..a335b7b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -109,3 +109,4 @@  cscope.*
 tags
 TAGS
 *~
+/tests/docker/*.docker.tmp