From patchwork Mon Mar 14 18:26:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pooja Dhannawat X-Patchwork-Id: 8583531 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F9F79F294 for ; Mon, 14 Mar 2016 18:29:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BA0AE2026D for ; Mon, 14 Mar 2016 18:29:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20A1920260 for ; Mon, 14 Mar 2016 18:29:05 +0000 (UTC) Received: from localhost ([::1]:43306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afXEl-0006jF-Uq for patchwork-qemu-devel@patchwork.kernel.org; Mon, 14 Mar 2016 14:29:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afXEa-0006gB-AC for qemu-devel@nongnu.org; Mon, 14 Mar 2016 14:28:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afXEW-0007Op-9x for qemu-devel@nongnu.org; Mon, 14 Mar 2016 14:28:52 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:35484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afXEW-0007Ol-2k for qemu-devel@nongnu.org; Mon, 14 Mar 2016 14:28:48 -0400 Received: by mail-pf0-x241.google.com with SMTP id u190so10510385pfb.2 for ; Mon, 14 Mar 2016 11:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=rj9mrYfheAQvDpJk2fkmWLYBXMmztakX37sp/BOOYSE=; b=Sq86zKmljYBXBYD5Fqw/6f7BAP5fYuA6tXj8wTt4a9a1y1LCfb1auvpd3oZFxFsQfX 7GD57C7PiFAmcAdsBZa9/z8EmFqqk0nJjE87bi4+m18i6oWY/MJnWYheSCBFNhC9XNNB vXqaPOwj6p6JEnDdiqW1hJ3fyJL02xof4j+iAEHm3An2Uj3EoJrUxGRfd4qgIGQGV0he nsa4xAZqHEhdHyqNdamY9fnbGhv9DHeMS/i9FJmuAMtrBFlmrXmR50q+rh+Q/6eDbtqW 9W12ms3yRU5JElOOHU+g0ztFWw+Rb4rHjIhgYoQqK8JXJdKKyr7CORHyuV9aPw5/ezZu OEMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=rj9mrYfheAQvDpJk2fkmWLYBXMmztakX37sp/BOOYSE=; b=DYTjNhq0BrYShAAnqiRDEDAZ1DfZLzIE6U1kgV0Q48FWUMThhQGxKQMw5jVVbX7llt WU0YwSmDDCxN/U41nMw3jJ1shokx7afLDPDaW9Pd8A7mylNKd1fr+G0egpYZCpFSyTap r7DSQ8z+yj2KsIoIIEZ/tHd/WmV1XrbDcW3au+UUr6nNvMtNMG3LVA6H9gXJKxEChAUi D6eytK4Yl5Ow1dsxJgopCaAbyFxfvhdLrT+A4+nXLV+evse7QOUl6mPFaZ98pg5Ivc9O jmqfMq4W6H/Pdq9TY51Q/OUcE5nx4kkecahVUCLyjuirN6ZsJajsum8QOlFvE5k+h9P6 R+Rw== X-Gm-Message-State: AD7BkJLXk6KdO+7n8oV3B0eNsx+psxNG9TNKqKYVV0JFlkxpUeYYvNfMlNnYH1048Hf6iQ== X-Received: by 10.98.67.195 with SMTP id l64mr32097463pfi.111.1457980127184; Mon, 14 Mar 2016 11:28:47 -0700 (PDT) Received: from localhost.localdomain ([183.87.60.98]) by smtp.gmail.com with ESMTPSA id n68sm33804386pfj.46.2016.03.14.11.28.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Mar 2016 11:28:46 -0700 (PDT) From: Pooja Dhannawat To: qemu-devel@nongnu.org Date: Mon, 14 Mar 2016 23:56:42 +0530 Message-Id: <1457980002-2513-1-git-send-email-dhannawatpooja1@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457771973-23208-1-git-send-email-dhannawatpooja1@gmail.com> References: <1457771973-23208-1-git-send-email-dhannawatpooja1@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH v2] net: Allocating Large sized arrays to heap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP nc_sendv_compat has a huge stack usage of 69680 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Pooja Dhannawat --- net/net.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index b0c832e..89589c0 100644 --- a/net/net.c +++ b/net/net.c @@ -709,23 +709,29 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size) static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, int iovcnt, unsigned flags) { - uint8_t buf[NET_BUFSIZE]; + uint8_t *buf; uint8_t *buffer; size_t offset; + ssize_t ret; + + buf = g_new(uint8_t, NET_BUFSIZE); if (iovcnt == 1) { buffer = iov[0].iov_base; offset = iov[0].iov_len; } else { buffer = buf; - offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); + offset = iov_to_buf(iov, iovcnt, 0, (uint8_t *)buf, NET_BUFSIZE); } if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { - return nc->info->receive_raw(nc, buffer, offset); + ret = nc->info->receive_raw(nc, buffer, offset); } else { - return nc->info->receive(nc, buffer, offset); + ret = nc->info->receive(nc, buffer, offset); } + + g_free(buf); + return ret; } ssize_t qemu_deliver_packet_iov(NetClientState *sender,