From patchwork Tue Mar 15 20:04:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 8592251 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9D75E9F44D for ; Tue, 15 Mar 2016 20:12:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EF6062020F for ; Tue, 15 Mar 2016 20:12:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD67C2014A for ; Tue, 15 Mar 2016 20:12:57 +0000 (UTC) Received: from localhost ([::1]:51234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afvKr-0006IB-41 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 15 Mar 2016 16:12:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afvDi-00083m-8u for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afvDd-0008IW-Sl for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:30 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:33667 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afvDd-0008HZ-HQ for qemu-devel@nongnu.org; Tue, 15 Mar 2016 16:05:29 -0400 Received: from kvm.sw.ru. ([10.28.8.145]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id u2FK4bCm005992; Tue, 15 Mar 2016 23:05:10 +0300 (MSK) From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Date: Tue, 15 Mar 2016 23:04:18 +0300 Message-Id: <1458072268-53705-13-git-send-email-vsementsov@virtuozzo.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1458072268-53705-1-git-send-email-vsementsov@virtuozzo.com> References: <1458072268-53705-1-git-send-email-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: OpenBSD 3.x X-Received-From: 195.214.232.25 Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, famz@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org, jsnow@redhat.com Subject: [Qemu-devel] [PATCH 12/22] qcow2-dirty-bitmap: add qcow2_bitmap_load_check() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function checks existing of the bitmap without loading it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 15 +++++++++++++++ block/qcow2-dirty-bitmap.c | 5 +++++ block/qcow2.c | 1 + block/qcow2.h | 1 + include/block/block_int.h | 2 ++ include/block/dirty-bitmap.h | 1 + 6 files changed, 25 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 816c6ee..7a44722 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -419,3 +419,18 @@ int bdrv_dirty_bitmap_store(const BdrvDirtyBitmap *bitmap, BlockDriverState *bs, { return hbitmap_store(bitmap->bitmap, bs, table, table_size, cluster_size); } + +bool bdrv_load_check_dirty_bitmap(BlockDriverState *file, const char *name) +{ + BlockDriver *drv = file->drv; + if (!drv) { + return false; + } + if (drv->bdrv_dirty_bitmap_load_check) { + return drv->bdrv_dirty_bitmap_load_check(file, name); + } + if (file->file) { + return bdrv_load_check_dirty_bitmap(file->file->bs, name); + } + return false; +} diff --git a/block/qcow2-dirty-bitmap.c b/block/qcow2-dirty-bitmap.c index 28ed309..24415df 100644 --- a/block/qcow2-dirty-bitmap.c +++ b/block/qcow2-dirty-bitmap.c @@ -276,6 +276,11 @@ static int load_bitmap_data(BlockDriverState *bs, const uint64_t *bitmap_table, return ret; } +bool qcow2_bitmap_load_check(BlockDriverState *file, const char *name) +{ + return find_bitmap_by_name(file, name) != NULL; +} + static BdrvDirtyBitmap *load_bitmap(BlockDriverState *bs, QCow2Bitmap *bm, Error **errp) { diff --git a/block/qcow2.c b/block/qcow2.c index bda3026..7a342c2 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3442,6 +3442,7 @@ BlockDriver bdrv_qcow2 = { .bdrv_get_specific_info = qcow2_get_specific_info, .bdrv_dirty_bitmap_load = qcow2_bitmap_load, + .bdrv_dirty_bitmap_load_check = qcow2_bitmap_load_check, .bdrv_dirty_bitmap_store = qcow2_bitmap_store, .bdrv_save_vmstate = qcow2_save_vmstate, diff --git a/block/qcow2.h b/block/qcow2.h index e4a517c..423c279 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -620,6 +620,7 @@ int qcow2_read_snapshots(BlockDriverState *bs); void qcow2_free_bitmaps(BlockDriverState *bs); int qcow2_read_bitmaps(BlockDriverState *bs, Error **errp); +bool qcow2_bitmap_load_check(BlockDriverState *file, const char *name); BdrvDirtyBitmap *qcow2_bitmap_load(BlockDriverState *bs, const char *name, Error **errp); void qcow2_bitmap_store(BlockDriverState *bs, const BdrvDirtyBitmap *bitmap, diff --git a/include/block/block_int.h b/include/block/block_int.h index 7cd05e1..66a388a 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -215,6 +215,8 @@ struct BlockDriver { int (*bdrv_get_info)(BlockDriverState *bs, BlockDriverInfo *bdi); ImageInfoSpecific *(*bdrv_get_specific_info)(BlockDriverState *bs); + bool (*bdrv_dirty_bitmap_load_check)(BlockDriverState *file, + const char *name); BdrvDirtyBitmap *(*bdrv_dirty_bitmap_load)(BlockDriverState *bs, const char *name, Error **errp); diff --git a/include/block/dirty-bitmap.h b/include/block/dirty-bitmap.h index 20cb540..f3cedaa 100644 --- a/include/block/dirty-bitmap.h +++ b/include/block/dirty-bitmap.h @@ -53,5 +53,6 @@ int bdrv_dirty_bitmap_prepare_store(const BdrvDirtyBitmap *bitmap, int bdrv_dirty_bitmap_store(const BdrvDirtyBitmap *bitmap, BlockDriverState *bs, const uint64_t *table, uint32_t table_size, uint32_t cluster_size); +bool bdrv_load_check_dirty_bitmap(BlockDriverState *file, const char *name); #endif