diff mbox

[2/7] block: make bdrv_start_throttled_reqs return void

Message ID 1458837566-108527-3-git-send-email-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paolo Bonzini March 24, 2016, 4:39 p.m. UTC 
The return value is unused and I am not sure why it would be useful.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/io.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Alberto Garcia March 29, 2016, 2:02 p.m. UTC | #1 
On Thu 24 Mar 2016 05:39:21 PM CET, Paolo Bonzini wrote:
> The return value is unused and I am not sure why it would be useful.

Yeah, this is not needed since 0b06ef3bdd177.

Reviewed-by: Alberto Garcia <berto@igalia.com>

>          while (qemu_co_enter_next(&bs->throttled_reqs[i])) {
> -            drained = true;
> +            ;
>          }

Is that semicolon necessary, though?

Berto
diff mbox

Patch

diff --git a/block/io.c b/block/io.c
index cbba269..3703426 100644
--- a/block/io.c
+++ b/block/io.c
@@ -69,10 +69,8 @@  void bdrv_set_io_limits(BlockDriverState *bs,
     }
 }
 
-/* this function drain all the throttled IOs */
-static bool bdrv_start_throttled_reqs(BlockDriverState *bs)
+static void bdrv_start_throttled_reqs(BlockDriverState *bs)
 {
-    bool drained = false;
     bool enabled = bs->io_limits_enabled;
     int i;
 
@@ -80,13 +78,11 @@  static bool bdrv_start_throttled_reqs(BlockDriverState *bs)
 
     for (i = 0; i < 2; i++) {
         while (qemu_co_enter_next(&bs->throttled_reqs[i])) {
-            drained = true;
+            ;
         }
     }
 
     bs->io_limits_enabled = enabled;
-
-    return drained;
 }
 
 void bdrv_io_limits_disable(BlockDriverState *bs)