From patchwork Thu Mar 24 16:39:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8662581 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DD41CC0553 for ; Thu, 24 Mar 2016 16:40:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D684203A1 for ; Thu, 24 Mar 2016 16:40:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD869203A0 for ; Thu, 24 Mar 2016 16:40:46 +0000 (UTC) Received: from localhost ([::1]:51807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj8JS-0002px-3l for patchwork-qemu-devel@patchwork.kernel.org; Thu, 24 Mar 2016 12:40:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj8II-0000xv-2g for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj8IG-0001WL-TO for qemu-devel@nongnu.org; Thu, 24 Mar 2016 12:39:33 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj8IG-0001WE-KI; Thu, 24 Mar 2016 12:39:32 -0400 Received: by mail-wm0-x243.google.com with SMTP id l68so14124671wml.3; Thu, 24 Mar 2016 09:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EIzqiRHjIx+Qpa3NgzKVVYC7VNEY4n94dzpT4tAguvE=; b=YpxdNPVqMpmqP2k4RSlzt/FSp8+S7kilIRuwamkDtzjcDseGK1Fc0rqYb+tQlIejIX d1madY5jDCjlL1tW6/cxe2lwLSsT7ws49uWWadPkqVXuwAMQ3EgjW+/ssx3fotW+H6aK VgWUNkcrTYYFyGuwH1tE+xvG0NAMZekB2Ap2TIZo+UFs4wAEyW3h2zTMmk0iG2uA6Wkk 9zGJ1Z13vgKnUL3Fdxqcy23tZ9nhj8rm8ErZQuENehcuT9ybln3AJZXDc3T0kAyixCqi KfaMxJEGQ3EB3WYSnO6z5vrDgYXGDxgfx3c2ZKk/369wQVmkTgrecmBn4zmLKdA3GNzX VTFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=EIzqiRHjIx+Qpa3NgzKVVYC7VNEY4n94dzpT4tAguvE=; b=GwFODGTrtlHRcItJNDBarSJ9L0a1kARSQFSgqN5ayY6zDI1RsD4BaPPIg+048xNm5x MKgvB/+H1OducMoyYyDyibEeNo4benkSyxeM4JiLBuel2fv+9Ncuz7nJ0ISEsB5gKXlt PX98c450I9xN/WKxZUv1zcJHueX/ZtAXi2rWodsfKCH2Y4N06WvUmpIysAsChJhQ3eDx 4ez4foVYy2ZgaNeJb7iWlva7KtrZluqO4eZI1wur4ANKqgi68ETHZxORB4ArUAz+UplK aGNXn+g0I2FKWNVzVjgyyIZGy4oSY5465yIVjXyPN7kWAqpLdOfoQ808lU9x7AWyUtfa CWog== X-Gm-Message-State: AD7BkJK8DGeryvJQcErtbLYxTJuzq++QEiCDuyTNKgqO4Ox/QJ8v1Tb53wfRGCku2r0uKw== X-Received: by 10.194.76.72 with SMTP id i8mr10862900wjw.117.1458837571995; Thu, 24 Mar 2016 09:39:31 -0700 (PDT) Received: from 640k.lan (94-39-161-17.adsl-ull.clienti.tiscali.it. [94.39.161.17]) by smtp.gmail.com with ESMTPSA id w125sm8508814wmw.18.2016.03.24.09.39.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Mar 2016 09:39:31 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 24 Mar 2016 17:39:21 +0100 Message-Id: <1458837566-108527-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1458837566-108527-1-git-send-email-pbonzini@redhat.com> References: <1458837566-108527-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Cc: kwolf@redhat.com, famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org Subject: [Qemu-devel] [PATCH 2/7] block: make bdrv_start_throttled_reqs return void X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini Reviewed-by: Alberto Garcia --- block/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index cbba269..3703426 100644 --- a/block/io.c +++ b/block/io.c @@ -69,10 +69,8 @@ void bdrv_set_io_limits(BlockDriverState *bs, } } -/* this function drain all the throttled IOs */ -static bool bdrv_start_throttled_reqs(BlockDriverState *bs) +static void bdrv_start_throttled_reqs(BlockDriverState *bs) { - bool drained = false; bool enabled = bs->io_limits_enabled; int i; @@ -80,13 +78,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs) for (i = 0; i < 2; i++) { while (qemu_co_enter_next(&bs->throttled_reqs[i])) { - drained = true; + ; } } bs->io_limits_enabled = enabled; - - return drained; } void bdrv_io_limits_disable(BlockDriverState *bs)