From patchwork Mon Mar 28 13:59:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 8679461 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2710B9F54E for ; Mon, 28 Mar 2016 14:01:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74CA4201ED for ; Mon, 28 Mar 2016 14:01:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9BB22015E for ; Mon, 28 Mar 2016 14:01:38 +0000 (UTC) Received: from localhost ([::1]:41065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akXjd-0001Aq-TM for patchwork-qemu-devel@patchwork.kernel.org; Mon, 28 Mar 2016 10:01:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akXjS-00019e-Di for qemu-devel@nongnu.org; Mon, 28 Mar 2016 10:01:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akXjN-0000kT-Bz for qemu-devel@nongnu.org; Mon, 28 Mar 2016 10:01:26 -0400 Received: from resqmta-po-04v.sys.comcast.net ([96.114.154.163]:44870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akXjN-0000kK-5r for qemu-devel@nongnu.org; Mon, 28 Mar 2016 10:01:21 -0400 Received: from resomta-po-01v.sys.comcast.net ([96.114.154.225]) by comcast with SMTP id kXgdaZgKDxtnBkXhPau08y; Mon, 28 Mar 2016 13:59:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1459173559; bh=V/CkTgPM81P5PZPE094wGcr7N4JqD1Tn8ZqB0u5KzOE=; h=Received:Received:From:To:Subject:Date:Message-Id; b=rOWwR0fcGYkkqKndT1XisaImw22nkpoVa5xswoOXGM+AsIAEeWNWb18SZSfn3OcTW ivT6wWIA6wGOgD51Yu/GR1aqwczT+mzEcHS4vMzRDcusB8fK2VpXMsthE7xm2tAj7e NkCTx2sbUSOKnMM9VrXVhyfMDZoG4Nwz3v3O2tJ9Jrv/MnLMlEH3zd9GU0Ka2rErQS MWBniOGFl1JgNxjRk3YLVW5ZkhJZGtS4py8Fe7wte0Cb/tYJ+DYjWx0Op/azAbMmxq 8Y/q7lmLhkEmFTt+BSQil70Sd9+mLgFjL40BIaHU23Oi7UQIK8RZAX/bL0eQeBxBUg 5df2xSb/uyQ8Q== Received: from red.redhat.com ([24.10.254.122]) by resomta-po-01v.sys.comcast.net with comcast id bRzF1s00G2fD5rL01RzJva; Mon, 28 Mar 2016 13:59:19 +0000 From: Eric Blake To: nbd-general@lists.sourceforge.net Date: Mon, 28 Mar 2016 07:59:15 -0600 Message-Id: <1459173555-4890-1-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 2.5.5 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.114.154.163 Cc: w@uter.be, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] doc: Mention proper use of handle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Although the proper use of the handle field during transmission phase was implied, it never hurts to make it more explicit that clients should alter the handle on each message, and the server repeat the handle unchanged, in order for the client to track when the server is sending replies out of order. Signed-off-by: Eric Blake --- doc/proto.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/proto.md b/doc/proto.md index 6d1cb34..d0102e0 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -200,7 +200,11 @@ S: 64 bits, handle S: (*length* bytes of data if the request is of type `NBD_CMD_READ`) Replies need not be sent in the same order as requests (i.e., requests -may be handled by the server asynchronously). +may be handled by the server asynchronously). Clients SHOULD send a +different value of handle for each request, and the server MUST use the +same value for handle as was sent by the client for each request that +the server is replying to, so that the client may correlate which +request is receiving a response. ## Values