diff mbox

[RFC,v2,1/9] virtio: fix stray tab character

Message ID 1459267981-23408-2-git-send-email-stefanha@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Hajnoczi March 29, 2016, 4:12 p.m. UTC 
The patches fixes a single occurrence of a tab character that resulted
in mis-aligned indentation.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
---
 hw/virtio/virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster April 7, 2016, 2:50 p.m. UTC | #1 
Stefan Hajnoczi <stefanha@redhat.com> writes:

> The patches fixes a single occurrence of a tab character that resulted

"The patch fixes" or "Fix", or drop the sentence.

> in mis-aligned indentation.

Really?  It comes out aligned in my editor.

> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Fam Zheng <famz@redhat.com>
Stefan Hajnoczi April 8, 2016, 9:06 a.m. UTC | #2 
On Thu, Apr 07, 2016 at 04:50:18PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi <stefanha@redhat.com> writes:
> 
> > The patches fixes a single occurrence of a tab character that resulted
> 
> "The patch fixes" or "Fix", or drop the sentence.
> 
> > in mis-aligned indentation.
> 
> Really?  It comes out aligned in my editor.

If your editor uses an unholy 8 space tab width setting then it will
appear correct.  But deep down we'll both know it's wrong :).

(I'm using tab width 4.)

Stefan
Markus Armbruster April 8, 2016, 11:10 a.m. UTC | #3 
Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Thu, Apr 07, 2016 at 04:50:18PM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi <stefanha@redhat.com> writes:
>> 
>> > The patches fixes a single occurrence of a tab character that resulted
>> 
>> "The patch fixes" or "Fix", or drop the sentence.
>> 
>> > in mis-aligned indentation.
>> 
>> Really?  It comes out aligned in my editor.
>
> If your editor uses an unholy 8 space tab width setting then it will
> appear correct.  But deep down we'll both know it's wrong :).
>
> (I'm using tab width 4.)

Heretic!
diff mbox

Patch

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 08275a9..de8a3b3 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1531,7 +1531,7 @@  int virtio_load(VirtIODevice *vdev, QEMUFile *f, int version_id)
                          "inconsistent with Host index 0x%x",
                          i, vdev->vq[i].last_avail_idx);
                 return -1;
-	}
+        }
         if (k->load_queue) {
             ret = k->load_queue(qbus->parent, i, f);
             if (ret)