From patchwork Tue Mar 29 23:00:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 8691561 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D0125C0553 for ; Tue, 29 Mar 2016 23:04:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2A9492034B for ; Tue, 29 Mar 2016 23:04:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 064852034C for ; Tue, 29 Mar 2016 23:04:30 +0000 (UTC) Received: from localhost ([::1]:50423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al2gX-0008Rw-HT for patchwork-qemu-devel@patchwork.kernel.org; Tue, 29 Mar 2016 19:04:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al2fT-0006mV-6r for qemu-devel@nongnu.org; Tue, 29 Mar 2016 19:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1al2fN-0006Pi-S5 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 19:03:21 -0400 Received: from resqmta-po-09v.sys.comcast.net ([96.114.154.168]:46257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al2fN-0006PV-Nh for qemu-devel@nongnu.org; Tue, 29 Mar 2016 19:03:17 -0400 Received: from resomta-po-04v.sys.comcast.net ([96.114.154.228]) by comcast with SMTP id l2cVakZqEZ5Fxl2dOaYaeb; Tue, 29 Mar 2016 23:01:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1459292474; bh=/mksTF1zeDTK7SFGxYuBF0tIH+VZ0H2f69m8XGEWTNo=; h=Received:Received:From:To:Subject:Date:Message-Id; b=n8Xxs50sWMOUYD6oaFH2sihB5o9G35OFrw4SrOhdM7FH+gmprfPqIRe7OeR6HT522 Z6zRa9ZczIhO3Y6Zt45QErQKqHc6DsH/MIJpY1xORCTqlx6+0NatiAiIgp2KtSCB8B ZXscCJhXnQAwaHzDtVEodPLjyW1THddn9coo6RWNGFgOnymMHZqH+tCod2UehVk4lS g6wOtBiqTpyQaNoABpFzpMyJYNSwPDjm1Ux0/Wfuo0VP+DbzQoQfv6Kv79oYYE0UkS i9jRdEQvy8NcpRyaWIVRKTY05QkY03KS2CBRe2OrwCU0+6mT7KW8aGPxs9mmfA7h5F Oj2FHfZoCf37g== Received: from red.redhat.com ([24.10.254.122]) by resomta-po-04v.sys.comcast.net with comcast id bz111s0012fD5rL01z1DH4; Tue, 29 Mar 2016 23:01:14 +0000 From: Eric Blake To: nbd-general@lists.sourceforge.net Date: Tue, 29 Mar 2016 17:00:58 -0600 Message-Id: <1459292460-6875-2-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1459292460-6875-1-git-send-email-eblake@redhat.com> References: <1459173555-4890-1-git-send-email-eblake@redhat.com> <1459292460-6875-1-git-send-email-eblake@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 96.114.154.168 Cc: "Denis V. Lunev" , w@uter.be, qemu-devel@nongnu.org, alex@alex.org.uk, Pavel Borzenkov Subject: [Qemu-devel] [PATCH v2 1/3] NBD proto: add "Command flags" section X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Pavel Borzenkov Add separate "Command flags" section to make it clear which flags are currently defined by the protocol. Signed-off-by: Pavel Borzenkov Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Wouter Verhelst CC: Alex Bligh Message-Id: <1459161798-32120-4-git-send-email-den@openvz.org> [rearrange subsections to parallel Handshake phase, add more details] Signed-off-by: Eric Blake --- doc/proto.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/doc/proto.md b/doc/proto.md index aaae0a2..3d49162 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -411,6 +411,20 @@ case that data is an error message suitable for display to the user. ### Transmission phase +#### Command flags + +This field of 16 bits is sent by the client with every request and provides +additional information to the server to execute the command. Refer to +the "Request types" section below for more details about how a given flag +affects a particular command. Clients MUST NOT set a command flag bit +that is not documented for the particular command; and whether a flag is +valid may depend on negotiation during the handshake phase. + +- bit 0, `NBD_CMD_FLAG_FUA`; valid during `NBD_CMD_WRITE`. SHOULD be + set to 1 if the client requires "Force Unit Access" mode of + operation. MUST NOT be set unless export flags included + `NBD_FLAG_SEND_FUA`. + #### Request types The following request types exist: