From patchwork Wed Mar 30 13:35:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 8696331 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 233EDC0553 for ; Wed, 30 Mar 2016 13:35:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8ACD32035B for ; Wed, 30 Mar 2016 13:35:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B95FC2020F for ; Wed, 30 Mar 2016 13:35:26 +0000 (UTC) Received: from localhost ([::1]:54204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGHN-0002Jy-6J for patchwork-qemu-devel@patchwork.kernel.org; Wed, 30 Mar 2016 09:35:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGHB-0002JW-7j for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alGH7-0005Jf-89 for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:35:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alGH7-0005JV-3H for qemu-devel@nongnu.org; Wed, 30 Mar 2016 09:35:09 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id BBC07C049E17; Wed, 30 Mar 2016 13:35:08 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.34.112.60]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2UDZ7jM028898; Wed, 30 Mar 2016 09:35:07 -0400 From: Igor Mammedov To: qemu-devel@nongnu.org Date: Wed, 30 Mar 2016 15:35:06 +0200 Message-Id: <1459344906-46409-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com> References: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: crobinso@redhat.com, stefanb@us.ibm.com, mst@redhat.com Subject: [Qemu-devel] [PATCH] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Windows will fail it initialize TMP driver with the reason: 'device cannot find enough free resources' That happens because parent BUS doesn't describe MMIO resources used by TPM child device. Fix it by describing it in top-most parent bus scope PCI0. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 35180ef..784870e 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2167,6 +2167,11 @@ build_dsdt(GArray *table_data, GArray *linker, 0, pci->w64.begin, pci->w64.end - 1, 0, pci->w64.end - pci->w64.begin)); } + + if (misc->tpm_version != TPM_VERSION_UNSPEC) { + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE, + TPM_TIS_ADDR_SIZE, AML_READ_WRITE)); + } aml_append(scope, aml_name_decl("_CRS", crs)); /* reserve GPE0 block resources */