From patchwork Fri Apr 1 11:16:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 8722951 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0B722C0554 for ; Fri, 1 Apr 2016 11:19:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 94D1D203A4 for ; Fri, 1 Apr 2016 11:18:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE59820398 for ; Fri, 1 Apr 2016 11:18:58 +0000 (UTC) Received: from localhost ([::1]:43513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx6Q-0000Mk-Ag for patchwork-qemu-devel@patchwork.kernel.org; Fri, 01 Apr 2016 07:18:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx4C-0005BR-Pa for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alx4B-0001jm-Uz for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:40 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:36246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alx4B-0001ji-Qo for qemu-devel@nongnu.org; Fri, 01 Apr 2016 07:16:39 -0400 Received: by mail-qg0-x231.google.com with SMTP id w104so87977535qge.3 for ; Fri, 01 Apr 2016 04:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/de5VKh4X06+MIO8YN8OtGoKchCF9eLEVCxtgf63ssg=; b=wyTIrqr+nY8kGmFbWKGxSU/n3ja5kpf1ZsO0G5OqwDnZeIFOCH6HP6y21s5VdJvhCR yO0hyr0qk7CTy6SsFXMbxj8athqeUWpIVep2QGe4afbGKbQL10513ta7hiKZwjr31p+z OsMW13XYtJJ6LHXK/rcNUUZ2AElbkCk86VWRgw5fEax9J54+SpyOnXNYtRzSF23lP0h3 lFG8DvLJoK2g2gxt8mR8WTFzF1QjNN89Zog8QtafcNb25/Cvcoh/dZC2v7Y1bmrefihc hmHp9cSo4/ry2nF40CqSwOHgMjH/XAbeGjhPBm+aeyWsybv1CcmE1vSd0QaY8pb7yoo9 SBnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/de5VKh4X06+MIO8YN8OtGoKchCF9eLEVCxtgf63ssg=; b=KQOt4Xn1Si5TT9GpQab4F0g2bJ5WXQc2TxGs9SI9YvrBiWWE0qHUrehmcrJyF+Wz4T CKN/S6dt2fHtMAgFO6tct/9zpZwHToeAvI6XbsF/SC1C+wv+t6evnvt8FEfI+Qbky+YE sY4JBA22Mqnr2OOee3fxxuC8WCpGZLczfXW0eRDMf0gUhoxHPybYqHpsyCBOtbB3hjvJ iXV4F+gQ5k89DPKCDwBWPMDr6bTYujqzEHSDj7Z0Jqw187uJ/d7c2zFT9XgpqL3TuVu3 JD4IXJXtz0ZUC34CUbaMLynJxeaydX3MKvB8fXTMOPLpW4WqnPO2bL+Gq9exRA3o+w1y uFrg== X-Gm-Message-State: AD7BkJL69+59v7iTNrURa/iyA3Mxk9lUeXXbRf7XSativ0Yp59Fj6CDXwrgOjOH1K/wDvQ== X-Received: by 10.140.250.4 with SMTP id v4mr25681247qhc.9.1459509399455; Fri, 01 Apr 2016 04:16:39 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id v11sm5875808qka.46.2016.04.01.04.16.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Apr 2016 04:16:38 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Fri, 1 Apr 2016 13:16:13 +0200 Message-Id: <1459509388-6185-4-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> References: <1459509388-6185-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c04::231 Cc: Yuanhan Liu , "Michael S. Tsirkin" , Ilya Maximets , jonshin@cisco.com, Tetsuya Mukawa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [Qemu-devel] [PATCH 03/18] char: use a trace for when the char is waiting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marc-André Lureau Similarly to the reconnect error, this is an information message rather than an error. Use a trace event instead. Signed-off-by: Marc-André Lureau --- qemu-char.c | 3 +-- trace-events | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a944ee0..8702931 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -4434,8 +4434,7 @@ static CharDriverState *qmp_chardev_open_socket(const char *id, } s->listen_ioc = sioc; if (is_waitconnect) { - fprintf(stderr, "QEMU waiting for connection on: %s\n", - chr->filename); + trace_char_socket_waiting(chr->filename); tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr); } qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL); diff --git a/trace-events b/trace-events index 19e0a05..e59c0f5 100644 --- a/trace-events +++ b/trace-events @@ -691,6 +691,7 @@ leon3_reset_irq(int intno) "Reset CPU IRQ %d" # qemu-char.c char_socket_reconnect_error(const char *label, const char *err) "Unable to connect character device %s: %s" +char_socket_waiting(const char *filename) "QEMU waiting for connection on: %s" # spice-qemu-char.c spice_vmc_write(ssize_t out, int len) "spice wrottn %zd of requested %d"