| Message ID | 1459849818-26649-11-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/05/2016 05:50 PM, Paolo Bonzini wrote: > From: Cao jin <caoj.fnst@cn.fujitsu.com> > > There is no memory_region_io(). And remove a stray '-'. > > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> > Message-Id: <1459507677-16662-1-git-send-email-caoj.fnst@cn.fujitsu.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > docs/memory.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/memory.txt b/docs/memory.txt > index 97134e1..f9272ca 100644 > --- a/docs/memory.txt > +++ b/docs/memory.txt > @@ -37,8 +37,8 @@ MemoryRegion): > > - MMIO: a range of guest memory that is implemented by host callbacks; > each read or write causes a callback to be called on the host. > - You initialize these with memory_region_io(), passing it a MemoryRegionOps > - structure describing the callbacks. > + You initialize these with memory_region_init_io(), passing it a > + MemoryRegionOps structure describing the callbacks. > > - ROM: a ROM memory region works like RAM for reads (directly accessing > a region of host memory), but like MMIO for writes (invoking a callback). > Hi Paolo, Seems the patch ignore the slight modification on that memory figure, So commit message isn`t consistent with the patch content. And actually I missed to remove a space between 7000 and 8000, since I removed a "-"
On 05/04/2016 11:59, Cao jin wrote: > Seems the patch ignore the slight modification on that memory figure, > So commit message isn`t consistent with the patch content. And actually > I missed to remove a space between 7000 and 8000, since I removed a "-" Oops, I forgot to adjust the commit message---I was about to answer on your message to explain why I removed the second hunk. Here: 0 1000 2000 3000 4000 5000 6000 7000 8000 |------|------|------|------|------|------|------|-------| A: [ ] C: [CCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC] B: [ ] It is correct to put 8000 right _after_ the closing bracket, because A ends at 0x7FFF. You can see how C and B are also aligned before the tick at 6000. Thanks, Paolo
diff --git a/docs/memory.txt b/docs/memory.txt index 97134e1..f9272ca 100644 --- a/docs/memory.txt +++ b/docs/memory.txt @@ -37,8 +37,8 @@ MemoryRegion): - MMIO: a range of guest memory that is implemented by host callbacks; each read or write causes a callback to be called on the host. - You initialize these with memory_region_io(), passing it a MemoryRegionOps - structure describing the callbacks. + You initialize these with memory_region_init_io(), passing it a + MemoryRegionOps structure describing the callbacks. - ROM: a ROM memory region works like RAM for reads (directly accessing a region of host memory), but like MMIO for writes (invoking a callback).