From patchwork Tue Apr 5 09:50:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8749171 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5A70F9F336 for ; Tue, 5 Apr 2016 09:50:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AA1A620373 for ; Tue, 5 Apr 2016 09:50:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E979620374 for ; Tue, 5 Apr 2016 09:50:57 +0000 (UTC) Received: from localhost ([::1]:35629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNdR-0003oN-AN for patchwork-qemu-devel@patchwork.kernel.org; Tue, 05 Apr 2016 05:50:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNdA-0003h6-Nd for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:50:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anNd6-0001CO-RW for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:50:40 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anNd6-0001Bk-DF for qemu-devel@nongnu.org; Tue, 05 Apr 2016 05:50:36 -0400 Received: by mail-wm0-x243.google.com with SMTP id i204so2689103wmd.0 for ; Tue, 05 Apr 2016 02:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=6qTe0/eYeHUmA8sogIH82kV2eiivkDjByZMJbz/5r3o=; b=j4Zyvhu/uzpW6lgtk7z+D5Adi18LfLHiFo9YGUeuA5BDX8wPxH+WIZG1V7cJe1jus+ XVI9i85BddokN3dtEcAmHFxuLimuAYVRQeaBHckIA79Pk2OAW/R0TQeVAGFIqetKjUmp QhBO5Bh9UUW5v3Fe2eh3/huBRt9cL9GmQskMcEvsS2f7HRzGGT9aMc/778fKsZMjQBv6 lkUj2CkK6Nq//POWDpSelYqqdfk9NPp5QuXC43dzHNRFmr7O5oltfi52yqSgkFfV2TpQ 3HSTxgn9FRLTXGa3kjRLAOL+H+atoUl8yYig1Qzb2sL3+d/VWFBytSn31BhC3LiodULK dDZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=6qTe0/eYeHUmA8sogIH82kV2eiivkDjByZMJbz/5r3o=; b=EpP5mkVi5YJDNgwqSGvazczcuIjnamIUhABa3DAV3FeFENPf4lfwWr1jGjVMVzImLa 59d//nOQCxLTrSFr5ns0v6d2UyuAqpxt/BN3nFe5slMQGLD5qQYcpctYN1qucxYMSXNR l/K+rHt3JqbzXUfQ3O9lGcf6kXd2j3UDAH4mg427RaJuCF+lKjzA3Do0zzoLiwvSA0iZ ttk35dr45rORx/OvA2AeemMhTRY5BHIFfxIGBs0kN3oP35W7Uib8uzcojcjqMup03h9R bb+Jcnxnyct70n0K3HDJFxlTxejOq26bnCbYOaVMLHblx3dVOwwBT7vK/GBOwqzuYLdx n3bg== X-Gm-Message-State: AD7BkJLIvvtokyWOauxsdip4ouZPKI8kjxZR248TAfUFrgh66JZ1/LloLpvIeeDzoPntWQ== X-Received: by 10.28.189.133 with SMTP id n127mr7689706wmf.5.1459849835790; Tue, 05 Apr 2016 02:50:35 -0700 (PDT) Received: from donizetti.lan (94-39-141-76.adsl-ull.clienti.tiscali.it. [94.39.141.76]) by smtp.gmail.com with ESMTPSA id ka4sm33721377wjc.47.2016.04.05.02.50.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Apr 2016 02:50:35 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 5 Apr 2016 11:50:14 +0200 Message-Id: <1459849818-26649-12-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1459849818-26649-1-git-send-email-pbonzini@redhat.com> References: <1459849818-26649-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Cc: Paolo Bonzini Subject: [Qemu-devel] [PULL 11/15] nbd: don't request FUA on FLUSH X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eric Blake The NBD protocol does not clearly document what will happen if a client sends NBD_CMD_FLAG_FUA on NBD_CMD_FLUSH. Historically, both the qemu and upstream NBD servers silently ignored that flag, but that feels a bit risky. Meanwhile, the qemu NBD client unconditionally sends the flag (without even bothering to check whether the caller cares; at least with NBD_CMD_WRITE the client only sends FUA if requested by a higher layer). There is ongoing discussion on the NBD list to fix the protocol documentation to require that the server MUST ignore the flag (unless the kernel folks can better explain what FUA means for a flush), but until those doc improvements land, the current nbd.git master was recently changed to reject the flag with EINVAL (see nbd commit ab22e082), which now makes it impossible for a qemu client to use FLUSH with an upstream NBD server. We should not send FUA with flush unless the upstream protocol documents what it will do, and even then, it should be something that the caller can opt into, rather than being unconditional. Signed-off-by: Eric Blake Message-Id: <1459526902-32561-1-git-send-email-eblake@redhat.com> Signed-off-by: Paolo Bonzini --- block/nbd-client.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index 021a88b..878e879 100644 --- a/block/nbd-client.c +++ b/block/nbd-client.c @@ -319,10 +319,6 @@ int nbd_client_co_flush(BlockDriverState *bs) return 0; } - if (client->nbdflags & NBD_FLAG_SEND_FUA) { - request.type |= NBD_CMD_FLAG_FUA; - } - request.from = 0; request.len = 0;