From patchwork Wed Apr 6 03:35:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 8757881 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 768C6C0553 for ; Wed, 6 Apr 2016 03:35:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5A7A22034A for ; Wed, 6 Apr 2016 03:35:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1F41202BE for ; Wed, 6 Apr 2016 03:35:33 +0000 (UTC) Received: from localhost ([::1]:40614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aneFg-0003cq-Q7 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 05 Apr 2016 23:35:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aneFU-0003cb-7o for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aneFP-0002N9-5T for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:20 -0400 Received: from resqmta-po-09v.sys.comcast.net ([2001:558:fe16:19:96:114:154:168]:33337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aneFO-0002ME-Uj for qemu-devel@nongnu.org; Tue, 05 Apr 2016 23:35:15 -0400 Received: from resomta-po-17v.sys.comcast.net ([96.114.154.241]) by comcast with SMTP id neFKaaVuSd826neFOavDNY; Wed, 06 Apr 2016 03:35:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1459913714; bh=nJZwbElp8uAziIgACWIqGpPZ+IcYfWlDm2GnaTRwpMk=; h=Received:Received:From:To:Subject:Date:Message-Id; b=SMNVYbi6W6i4vNHFCn23EL3wZEKTdx87VmFqOuxIRToJVfD40Bgj+u1Zffg/Biuh6 8N8hJxR3RnLxlcWxKLiXhAlOzqhY/Nm1YW0uMAnwPwGi2fcrbjGnTd4N/xkJE9xmBR wl1HY1PzXn/qS2F/rQIP+z7X7FEF1RJJauKylF4cxTvR87muXdOypU+y8x9ke3Ebnl 0xNfmfK+3d1eosHJNbngIXKIJ91xywlkc1Un874zEQLi1jKxoF2TFP/Fjb/VOscscq O4o3mk/MuIiZCzgvmSyiDk18IOls2bFTcEeQw71kcR1X50Utf12/AiTn3SSa243yve BIQuRArC9VoCA== Received: from red.redhat.com ([24.10.254.122]) by resomta-po-17v.sys.comcast.net with comcast id erb51s0052fD5rL01rbE7T; Wed, 06 Apr 2016 03:35:14 +0000 From: Eric Blake To: qemu-devel@nongnu.org Date: Tue, 5 Apr 2016 21:35:02 -0600 Message-Id: <1459913704-19949-2-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1459913704-19949-1-git-send-email-eblake@redhat.com> References: <1459913704-19949-1-git-send-email-eblake@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:558:fe16:19:96:114:154:168 Cc: pbonzini@redhat.com Subject: [Qemu-devel] [PATCH 1/3] nbd: Return correct error for write to read-only export X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The NBD Protocol requires that servers should send EPERM for attempts to write (or trim) a read-only export. We were correct for TRIM (blk_co_discard() gave EPERM); but were manually setting EROFS which then got mapped to EINVAL over the wire on writes. Signed-off-by: Eric Blake --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index b95571b..98e3957 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -26,6 +26,7 @@ static int system_errno_to_nbd_errno(int err) case 0: return NBD_SUCCESS; case EPERM: + case EROFS: return NBD_EPERM; case EIO: return NBD_EIO;