From patchwork Thu Apr 7 16:33:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8774841 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2C15C9FBEA for ; Thu, 7 Apr 2016 16:35:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82867201EC for ; Thu, 7 Apr 2016 16:35:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFBE720155 for ; Thu, 7 Apr 2016 16:35:27 +0000 (UTC) Received: from localhost ([::1]:51309 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoCtz-0004B8-6j for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Apr 2016 12:35:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoCsK-0001J4-EG for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:33:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoCsI-0005jV-Kr for qemu-devel@nongnu.org; Thu, 07 Apr 2016 12:33:44 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:36260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoCsI-0005jR-Dx; Thu, 07 Apr 2016 12:33:42 -0400 Received: by mail-wm0-x241.google.com with SMTP id l6so5683979wml.3; Thu, 07 Apr 2016 09:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=o8UwSTmR4lJMM2M6ES9lEq3SA9RQbqtRh/QGvMqRTkU=; b=qcq0C0iyiozWNK0MeFxpMne/LwyQ8lMzGZIf4Fr90O6hF5tJxxNpAlCMlBWqtxKXiK 42xeH640WpryaVSuIC2x94gCwgWCljx6j+KTA21TDTg0ZGjw8yg2lj2VYfonkaMhS30V ApmbZhSvbELIzg3SxiCxLR3RH7ZjitzOEUwUmQMq/l9EH1o71vwT2gEVC0l5pu9JGqVq 6FXibHbpszANECfUtvE2CmjaSp4IAHT9LaeVdJKd7V/sWCGpo+m7v25/7sF7PUSkXBqP 8/8Pern0aFgXeRpWXLzvfdxyUmauuvDoybD4DC+tKVIUiHY4ZDD7HuTr4wCK9eNNS1EQ seuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=o8UwSTmR4lJMM2M6ES9lEq3SA9RQbqtRh/QGvMqRTkU=; b=fwvHc435kWysOKCKM4rhnP8k9x80n334/x/SaNsl2dSbgwjRFb5tqkIQ79EpOyPKPp a8wJN6ktFi4TTa4zyf1r9Wqf3DM8Nk7NkOed0mw0xQwmRYF4zBOcUocBt4CzK8y95X93 P/XIKwJFzFSG7xNg+rXrbWwCjOjJeRXtoBPEzlivqmsOU6ceqWKZokUuVJI/GLl6OF2H wafcJw7Ngo9s5QfXzVaui/lWDul0dGfrSqRrhNY+GRfBwR78fmCcrev60aNP76ugdb18 WCAGfAADlkKcWJ1QvdKj+nyLWvgk9d+rFl8pzX6YWUAbmUxUy5ARy3RkutFX3uto/7hJ gO/Q== X-Gm-Message-State: AD7BkJKX5qlS8+fAK+E5pVqA2oPdvXWhHQvgcAX08Ml8SikIHr7azTns2K/ORzsCcisBiQ== X-Received: by 10.194.78.178 with SMTP id c18mr5090594wjx.114.1460046821769; Thu, 07 Apr 2016 09:33:41 -0700 (PDT) Received: from 640k.lan (94-39-141-76.adsl-ull.clienti.tiscali.it. [94.39.141.76]) by smtp.gmail.com with ESMTPSA id hh8sm9218862wjc.42.2016.04.07.09.33.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Apr 2016 09:33:40 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 7 Apr 2016 18:33:30 +0200 Message-Id: <1460046816-102846-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> References: <1460046816-102846-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 Cc: kwolf@redhat.com, berto@igalia.com, famz@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com Subject: [Qemu-devel] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index a91d862..691baa6 100644 --- a/block/io.c +++ b/block/io.c @@ -71,10 +71,8 @@ void bdrv_set_io_limits(BlockDriverState *bs, } } -/* this function drain all the throttled IOs */ -static bool bdrv_start_throttled_reqs(BlockDriverState *bs) +static void bdrv_start_throttled_reqs(BlockDriverState *bs) { - bool drained = false; bool enabled = bs->io_limits_enabled; int i; @@ -82,13 +80,11 @@ static bool bdrv_start_throttled_reqs(BlockDriverState *bs) for (i = 0; i < 2; i++) { while (qemu_co_enter_next(&bs->throttled_reqs[i])) { - drained = true; + ; } } bs->io_limits_enabled = enabled; - - return drained; } void bdrv_io_limits_disable(BlockDriverState *bs)