From patchwork Sat Apr 9 14:19:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 8788451 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1BC329FC82 for ; Sat, 9 Apr 2016 14:19:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B2CF202BE for ; Sat, 9 Apr 2016 14:19:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D54D7202B8 for ; Sat, 9 Apr 2016 14:19:32 +0000 (UTC) Received: from localhost ([::1]:60451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aotjY-0000QR-6G for patchwork-qemu-devel@patchwork.kernel.org; Sat, 09 Apr 2016 10:19:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aotjH-0000I3-Sr for qemu-devel@nongnu.org; Sat, 09 Apr 2016 10:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aotjH-0004N6-1y for qemu-devel@nongnu.org; Sat, 09 Apr 2016 10:19:15 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:32801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aotjG-0004N1-U2 for qemu-devel@nongnu.org; Sat, 09 Apr 2016 10:19:14 -0400 Received: by mail-qk0-x22c.google.com with SMTP id k135so50957989qke.0 for ; Sat, 09 Apr 2016 07:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qsIy9L1+ivQ/5FtGE86h51bSjO3C8z2hrZSLhygzIRY=; b=PqYxKSW5AKkUMj6xevA35ff32GlFvWi76duOj8CG7r5+KFLZLD9Sr3kAPKVIeVt5+9 NHvGjaj+5wDxkVT6EN38gUbMJmIViGoseJ+fLESo+jap21/GE25EhlSxvjf5Dovgp8wr uqX7hJbByGpbkJ4wFuLUw9CQy/WfIsoePh+O7OdlepNLKOg4cp/yz5Hjsql6++VB3lL7 x30Z0g3+J9PRJ49E/5asreRHUMqNJUEZs5q9S28dDLCUMGwR1NSzeWGWNevvsA8KxolV xPH8iUMq8P56+VtvJHEbpSnLOs/Kgs503+N2CqJRnVf/zj6vqavXwLgpnQxupzCBAmgq vsmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qsIy9L1+ivQ/5FtGE86h51bSjO3C8z2hrZSLhygzIRY=; b=jNTeV3nX8+zxS7H3lRNvPbEV8DX9hmAkJUhJhoXlLjlXmYPoYcnXzm2KVlGtPs0dgz YNHKCQMrVBHCrZ/Bam6aIiJbUAMls+z4Dd+p9YWUQ1WaQltlWbIgcsLNubSDnwS9skvr qs4Vm4I/sGDIKekIkC89+JWpWMYXMPDbr1yTxLFNcB4dyCUryT5qZ61yILnTuu7lAf2L VXPRRx0/v7Lg9SDWQ+UTYzcJXwpgNd956zfPNuUpzqqDrgF969P878nbnPThkRtxFcTh Lf9AMsZ4CsTAEMsz9APG4B7uAAbmGYKg3ln8t748TIeTGAqw+CdR4Y3/+EOfyMzMl9j0 aJ7g== X-Gm-Message-State: AD7BkJKCvnw3oDEScIJzoFPbw47LyIcHcPenIcqPqVsk/cyOIIdDW8wDn1henBOtZkf+QQ== X-Received: by 10.55.78.201 with SMTP id c192mr18283453qkb.9.1460211554578; Sat, 09 Apr 2016 07:19:14 -0700 (PDT) Received: from localhost (bne75-h02-31-39-163-232.dsl.sta.abo.bbox.fr. [31.39.163.232]) by smtp.gmail.com with ESMTPSA id t85sm7558579qki.10.2016.04.09.07.19.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Apr 2016 07:19:13 -0700 (PDT) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Date: Sat, 9 Apr 2016 16:19:03 +0200 Message-Id: <1460211547-9264-3-git-send-email-marcandre.lureau@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1460211547-9264-1-git-send-email-marcandre.lureau@redhat.com> References: <1460211547-9264-1-git-send-email-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22c Subject: [Qemu-devel] [RFC 2/6] vubr: remove unnecessary dispatcher_remove X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , victork@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Marc-André Lureau The call fd is not watched Signed-off-by: Marc-André Lureau --- tests/vhost-user-bridge.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 7d548d8..b9bf018 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -975,7 +975,6 @@ vubr_get_vring_base_exec(VubrDev *dev, VhostUserMsg *vmsg) if (dev->vq[index].call_fd != -1) { close(dev->vq[index].call_fd); - dispatcher_remove(&dev->dispatcher, dev->vq[index].call_fd); dev->vq[index].call_fd = -1; } if (dev->vq[index].kick_fd != -1) { @@ -1039,7 +1038,6 @@ vubr_set_vring_call_exec(VubrDev *dev, VhostUserMsg *vmsg) if (dev->vq[index].call_fd != -1) { close(dev->vq[index].call_fd); - dispatcher_remove(&dev->dispatcher, dev->vq[index].call_fd); } dev->vq[index].call_fd = vmsg->fds[0]; DPRINT("Got call_fd: %d for vq: %d\n", vmsg->fds[0], index);