diff mbox

[for-2.7,14/15] ide-test: Specify "lock-image=off" in command lines

Message ID 1460538604-12132-15-git-send-email-famz@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fam Zheng April 13, 2016, 9:10 a.m. UTC 
If a failure in a previous test case doesn't clean up the running qemu process
(it happens), the subsequent ones can fail because of a image locking failure.
That is not an authentic failure of the test case itself and could be sometimes
confusing.  Disable image locking to avoid that.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/ide-test.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/tests/ide-test.c b/tests/ide-test.c
index 0d9ab4d..004ea4f 100644
--- a/tests/ide-test.c
+++ b/tests/ide-test.c
@@ -504,7 +504,8 @@  static void test_flush(void)
     uint8_t data;
 
     ide_test_start(
-        "-drive file=blkdebug::%s,if=ide,cache=writeback,format=raw",
+        "-drive file=blkdebug::%s,if=ide,lock-image=off,"
+        "cache=writeback,format=raw",
         tmp_path);
 
     /* Delay the completion of the flush request until we explicitly do it */
@@ -546,7 +547,7 @@  static void test_retry_flush(const char *machine)
     ide_test_start(
         "-vnc none "
         "-drive file=blkdebug:%s:%s,if=ide,cache=writeback,format=raw,"
-        "rerror=stop,werror=stop",
+        "rerror=stop,werror=stop,lock-image=off",
         debug_path, tmp_path);
 
     /* FLUSH CACHE command on device 0*/