From patchwork Thu Apr 14 03:58:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Jiangang X-Patchwork-Id: 8831181 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5F47CC0553 for ; Thu, 14 Apr 2016 03:59:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 95109202EC for ; Thu, 14 Apr 2016 03:59:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7479202DD for ; Thu, 14 Apr 2016 03:59:23 +0000 (UTC) Received: from localhost ([::1]:58188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqYR9-00016M-9f for patchwork-qemu-devel@patchwork.kernel.org; Wed, 13 Apr 2016 23:59:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqYQz-00012R-UR for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:59:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqYQv-0001mi-AV for qemu-devel@nongnu.org; Wed, 13 Apr 2016 23:59:13 -0400 Received: from [59.151.112.132] (port=27106 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqYQu-0001mU-Pa; Wed, 13 Apr 2016 23:59:09 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="5584413" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 14 Apr 2016 11:59:05 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id EFF8F42B55E5; Thu, 14 Apr 2016 11:59:03 +0800 (CST) Received: from localhost.localdomain (10.167.226.50) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.279.2; Thu, 14 Apr 2016 11:59:03 +0800 From: Wei Jiangang To: Date: Thu, 14 Apr 2016 11:58:02 +0800 Message-ID: <1460606282-4570-1-git-send-email-weijg.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 X-Originating-IP: [10.167.226.50] X-yoursite-MailScanner-ID: EFF8F42B55E5.A04CB X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: weijg.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Subject: [Qemu-devel] [PATCH v2] accel: make configure_accelerator return void X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, xiecl.fnst@cn.fujitsu.com, Wei Jiangang Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return the negated value of accel_initialised is meaningless, and the caller vl doesn't check it. Signed-off-by: Wei Jiangang --- accel.c | 4 +--- include/sysemu/accel.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/accel.c b/accel.c index 0510b90..403eb5e 100644 --- a/accel.c +++ b/accel.c @@ -77,7 +77,7 @@ static int accel_init_machine(AccelClass *acc, MachineState *ms) return ret; } -int configure_accelerator(MachineState *ms) +void configure_accelerator(MachineState *ms) { const char *p; char buf[10]; @@ -128,8 +128,6 @@ int configure_accelerator(MachineState *ms) if (init_failed) { fprintf(stderr, "Back to %s accelerator.\n", acc->name); } - - return !accel_initialised; } diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 997720f..c230f1b 100644 --- a/include/sysemu/accel.h +++ b/include/sysemu/accel.h @@ -57,6 +57,6 @@ typedef struct AccelClass { extern int tcg_tb_size; -int configure_accelerator(MachineState *ms); +void configure_accelerator(MachineState *ms); #endif