| Message ID | 1461164130-3847-1-git-send-email-ehabkost@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 20, 2016 at 11:55:30AM -0300, Eduardo Habkost wrote: > When using K: in MAINTAINERS, false positives makes > get_maintainer.pl not use git history to find contributors. As > those patterns cause lots of false positives they are causing > more harm than good, so remove them. > > Reported-by: Markus Armbruster <armbru@redhat.com> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Peter, should I send a pull request just for this patch, or do you prefer to apply it directly?
On 20 April 2016 at 15:57, Eduardo Habkost <ehabkost@redhat.com> wrote: > On Wed, Apr 20, 2016 at 11:55:30AM -0300, Eduardo Habkost wrote: >> When using K: in MAINTAINERS, false positives makes >> get_maintainer.pl not use git history to find contributors. As >> those patterns cause lots of false positives they are causing >> more harm than good, so remove them. >> >> Reported-by: Markus Armbruster <armbru@redhat.com> >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > Peter, should I send a pull request just for this patch, or do > you prefer to apply it directly? I can just apply this directly. thanks -- PMM
On 20 April 2016 at 16:20, Peter Maydell <peter.maydell@linaro.org> wrote: > On 20 April 2016 at 15:57, Eduardo Habkost <ehabkost@redhat.com> wrote: >> On Wed, Apr 20, 2016 at 11:55:30AM -0300, Eduardo Habkost wrote: >>> When using K: in MAINTAINERS, false positives makes >>> get_maintainer.pl not use git history to find contributors. As >>> those patterns cause lots of false positives they are causing >>> more harm than good, so remove them. >>> >>> Reported-by: Markus Armbruster <armbru@redhat.com> >>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> >> >> Peter, should I send a pull request just for this patch, or do >> you prefer to apply it directly? > > I can just apply this directly. ...now applied, thanks. -- PMM
diff --git a/MAINTAINERS b/MAINTAINERS index 28e2b17..81e7fac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1155,8 +1155,6 @@ M: Eduardo Habkost <ehabkost@redhat.com> S: Maintained F: numa.c F: include/sysemu/numa.h -K: numa|NUMA -K: srat|SRAT T: git git://github.com/ehabkost/qemu.git numa QAPI
When using K: in MAINTAINERS, false positives makes get_maintainer.pl not use git history to find contributors. As those patterns cause lots of false positives they are causing more harm than good, so remove them. Reported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-)