diff mbox

cpu-exec: Remove relic orphaned comment

Message ID 1462286050-21778-1-git-send-email-sergey.fedorov@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

sergey.fedorov@linaro.org May 3, 2016, 2:34 p.m. UTC
From: Sergey Fedorov <serge.fdrv@gmail.com>

This comment should have been deleted by commit 0ac087f1f3ae ("removed
unused code") but somehow it is still here. There's no point to keep it.

Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>
---
 cpu-exec.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Sergey Fedorov May 3, 2016, 2:36 p.m. UTC | #1
On 03/05/16 17:34, Sergey Fedorov wrote:
> From: Sergey Fedorov <serge.fdrv@gmail.com>
>
> This comment should have been deleted by commit 0ac087f1f3ae ("removed
> unused code") but somehow it is still here. There's no point to keep it.
>
> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>

Sorry, should be:

	Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>

Also, this patch is based on a commit:
    3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
from:
    git://github.com/rth7680/qemu.git tcg-next

Kind regards,
Sergey

> ---
>  cpu-exec.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index d43d5ae729b6..d55faa5114c7 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -582,8 +582,6 @@ int cpu_exec(CPUState *cpu)
>                  /* Try to align the host and virtual clocks
>                     if the guest is in advance */
>                  align_clocks(&sc, cpu);
> -                /* reset soft MMU for next block (it can currently
> -                   only be set by a memory fault) */
>              } /* for(;;) */
>          } else {
>  #if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)
Richard Henderson May 4, 2016, 5:56 p.m. UTC | #2
On 05/03/2016 04:36 AM, Sergey Fedorov wrote:
> On 03/05/16 17:34, Sergey Fedorov wrote:
>> > From: Sergey Fedorov <serge.fdrv@gmail.com>
>> >
>> > This comment should have been deleted by commit 0ac087f1f3ae ("removed
>> > unused code") but somehow it is still here. There's no point to keep it.
>> >
>> > Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> > Signed-off-by: Sergey Fedorov <serge.fedorov@linaro.org>
> Sorry, should be:
>
> 	Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
>
> Also, this patch is based on a commit:
>     3c712db2c10b ("cpu-exec: Move TB chaining into tb_find_fast()")
> from:
>     git://github.com/rth7680/qemu.git tcg-next
>
> Kind regards,
> Sergey
>

Applied to tcg-next with the fixed s-o-b.

r~
diff mbox

Patch

diff --git a/cpu-exec.c b/cpu-exec.c
index d43d5ae729b6..d55faa5114c7 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -582,8 +582,6 @@  int cpu_exec(CPUState *cpu)
                 /* Try to align the host and virtual clocks
                    if the guest is in advance */
                 align_clocks(&sc, cpu);
-                /* reset soft MMU for next block (it can currently
-                   only be set by a memory fault) */
             } /* for(;;) */
         } else {
 #if defined(__clang__) || !QEMU_GNUC_PREREQ(4, 6)