| Message ID | 1462875216-10813-1-git-send-email-weijg.fnst@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
ping ... Any comments? On Tue, 2016-05-10 at 18:13 +0800, Wei Jiangang wrote: > spice-server-devel is required, not spice-protocol-devel. > "spice-protocol(>=0.12.3) devel" maybe mislead user. > > when configure isn't able to find the required usb-redir, > It's better to explicitly output version requirement. > > Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com> > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index c37fc5f..0190fb7 100755 > --- a/configure > +++ b/configure > @@ -3974,7 +3974,7 @@ EOF > else > if test "$spice" = "yes" ; then > feature_not_found "spice" \ > - "Install spice-server(>=0.12.0) and spice-protocol(>=0.12.3) devel" > + "Install spice-server(>=0.12.0) devel and spice-protocol(>=0.12.3)" > fi > spice="no" > fi > @@ -4023,7 +4023,7 @@ if test "$usb_redir" != "no" ; then > libs_softmmu="$libs_softmmu $usb_redir_libs" > else > if test "$usb_redir" = "yes"; then > - feature_not_found "usb-redir" "Install usbredir devel" > + feature_not_found "usb-redir" "Install usbredir devel(>=0.6)" > fi > usb_redir="no" > fi
diff --git a/configure b/configure index c37fc5f..0190fb7 100755 --- a/configure +++ b/configure @@ -3974,7 +3974,7 @@ EOF else if test "$spice" = "yes" ; then feature_not_found "spice" \ - "Install spice-server(>=0.12.0) and spice-protocol(>=0.12.3) devel" + "Install spice-server(>=0.12.0) devel and spice-protocol(>=0.12.3)" fi spice="no" fi @@ -4023,7 +4023,7 @@ if test "$usb_redir" != "no" ; then libs_softmmu="$libs_softmmu $usb_redir_libs" else if test "$usb_redir" = "yes"; then - feature_not_found "usb-redir" "Install usbredir devel" + feature_not_found "usb-redir" "Install usbredir devel(>=0.6)" fi usb_redir="no" fi
spice-server-devel is required, not spice-protocol-devel. "spice-protocol(>=0.12.3) devel" maybe mislead user. when configure isn't able to find the required usb-redir, It's better to explicitly output version requirement. Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com> --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)