diff mbox

[1/3] qemu-io: Fix missing getopt() updates

Message ID 1463089170-30550-2-git-send-email-eblake@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Blake May 12, 2016, 9:39 p.m. UTC 
Commit 770e0e0e [*] forgot to implement 'writev -f'.  Likewise,
commit c3e001c forgot to implement 'aio_write -u -z'.

[*] does it sound "ech0e" in here? :)

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 qemu-io-cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Max Reitz May 13, 2016, 11:55 a.m. UTC | #1 
On 12.05.2016 23:39, Eric Blake wrote:
> Commit 770e0e0e [*] forgot to implement 'writev -f'.  Likewise,
> commit c3e001c forgot to implement 'aio_write -u -z'.

*c2e001c

I can fix that while applying, though.

Max

> 
> [*] does it sound "ech0e" in here? :)
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  qemu-io-cmds.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index 4a00bc6..415be25 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -1150,7 +1150,7 @@ static int writev_f(BlockBackend *blk, int argc, char **argv)
>      int pattern = 0xcd;
>      QEMUIOVector qiov;
> 
> -    while ((c = getopt(argc, argv, "CqP:")) != -1) {
> +    while ((c = getopt(argc, argv, "CfqP:")) != -1) {
>          switch (c) {
>          case 'C':
>              Cflag = true;
> @@ -1595,7 +1595,7 @@ static int aio_write_f(BlockBackend *blk, int argc, char **argv)
>      int flags = 0;
> 
>      ctx->blk = blk;
> -    while ((c = getopt(argc, argv, "CfqP:z")) != -1) {
> +    while ((c = getopt(argc, argv, "CfqP:uz")) != -1) {
>          switch (c) {
>          case 'C':
>              ctx->Cflag = true;
>
Max Reitz May 13, 2016, noon UTC | #2 
On 13.05.2016 13:55, Max Reitz wrote:
> On 12.05.2016 23:39, Eric Blake wrote:
>> Commit 770e0e0e [*] forgot to implement 'writev -f'.  Likewise,
>> commit c3e001c forgot to implement 'aio_write -u -z'.
> 
> *c2e001c
> 
> I can fix that while applying, though.

(With that fixed:

Reviewed-by: Max Reitz <mreitz@redhat.com>

)
diff mbox

Patch

diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 4a00bc6..415be25 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -1150,7 +1150,7 @@  static int writev_f(BlockBackend *blk, int argc, char **argv)
     int pattern = 0xcd;
     QEMUIOVector qiov;

-    while ((c = getopt(argc, argv, "CqP:")) != -1) {
+    while ((c = getopt(argc, argv, "CfqP:")) != -1) {
         switch (c) {
         case 'C':
             Cflag = true;
@@ -1595,7 +1595,7 @@  static int aio_write_f(BlockBackend *blk, int argc, char **argv)
     int flags = 0;

     ctx->blk = blk;
-    while ((c = getopt(argc, argv, "CfqP:z")) != -1) {
+    while ((c = getopt(argc, argv, "CfqP:uz")) != -1) {
         switch (c) {
         case 'C':
             ctx->Cflag = true;