From patchwork Fri May 20 23:40:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 9130241 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DED8F60762 for ; Sat, 21 May 2016 00:10:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF89C27C23 for ; Sat, 21 May 2016 00:10:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C383D27D11; Sat, 21 May 2016 00:10:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3F8D427C23 for ; Sat, 21 May 2016 00:10:22 +0000 (UTC) Received: from localhost ([::1]:38304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3uUm-000499-Va for patchwork-qemu-devel@patchwork.kernel.org; Fri, 20 May 2016 20:10:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3u2F-0001WF-0N for qemu-devel@nongnu.org; Fri, 20 May 2016 19:40:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3u2C-0006TC-PG for qemu-devel@nongnu.org; Fri, 20 May 2016 19:40:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3u2C-0006T7-GV for qemu-devel@nongnu.org; Fri, 20 May 2016 19:40:48 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F30707DCFA; Fri, 20 May 2016 23:40:47 +0000 (UTC) Received: from localhost (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4KNehYf019355; Fri, 20 May 2016 19:40:45 -0400 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Fri, 20 May 2016 16:40:24 -0700 Message-Id: <1463787632-7241-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1463787632-7241-1-git-send-email-stefanha@redhat.com> References: <1463787632-7241-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 20 May 2016 23:40:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/9] virtio-blk: use batch notify in non-dataplane case X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Ming Lei , Ming Lei , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 5b2ffbe4d99843fd8305c573a100047a8c962327 ("virtio-blk: dataplane: notify guest as a batch") deferred guest notification to a BH in order batch notifications. This optimization is not specific to dataplane so move it to the generic virtio-blk code that is shared by both dataplane and non-dataplane code. Note that this patch adds a flush function to force pending notifications. This way we can ensure notifications do not cross device reset or vmstate saving. Cc: Ming Lei Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 10 ---------- hw/block/virtio-blk.c | 37 +++++++++++++++++++++++++++++++------ include/hw/virtio/virtio-blk.h | 1 + 3 files changed, 32 insertions(+), 16 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 3cb97c9..e0ac4f4 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -35,7 +35,6 @@ struct VirtIOBlockDataPlane { VirtIODevice *vdev; VirtQueue *vq; /* virtqueue vring */ EventNotifier *guest_notifier; /* irq */ - QEMUBH *bh; /* bh for guest notification */ Notifier insert_notifier, remove_notifier; @@ -54,13 +53,6 @@ struct VirtIOBlockDataPlane { /* Raise an interrupt to signal guest, if necessary */ void virtio_blk_data_plane_notify(VirtIOBlockDataPlane *s) { - qemu_bh_schedule(s->bh); -} - -static void notify_guest_bh(void *opaque) -{ - VirtIOBlockDataPlane *s = opaque; - if (!virtio_should_notify(s->vdev, s->vq)) { return; } @@ -156,7 +148,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf, object_ref(OBJECT(s->iothread)); } s->ctx = iothread_get_aio_context(s->iothread); - s->bh = aio_bh_new(s->ctx, notify_guest_bh, s); s->insert_notifier.notify = data_plane_blk_insert_notifier; s->remove_notifier.notify = data_plane_blk_remove_notifier; @@ -179,7 +170,6 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s) data_plane_remove_op_blockers(s); notifier_remove(&s->insert_notifier); notifier_remove(&s->remove_notifier); - qemu_bh_delete(s->bh); object_unref(OBJECT(s->iothread)); g_free(s); } diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 284e646..0eaf6bf 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -45,20 +45,37 @@ void virtio_blk_free_request(VirtIOBlockReq *req) } } +/* Many requests can complete in an event loop iteration, we only notify the + * guest once. + */ +static void virtio_blk_batch_notify_bh(void *opaque) +{ + VirtIOBlock *s = opaque; + VirtIODevice *vdev = VIRTIO_DEVICE(s); + + if (s->dataplane_started && !s->dataplane_disabled) { + virtio_blk_data_plane_notify(s->dataplane); + } else { + virtio_notify(vdev, s->vq); + } +} + +/* Force batch notifications to run */ +static void virtio_blk_batch_notify_flush(VirtIOBlock *s) +{ + qemu_bh_cancel(s->batch_notify_bh); + virtio_blk_batch_notify_bh(s); +} + static void virtio_blk_req_complete(VirtIOBlockReq *req, unsigned char status) { VirtIOBlock *s = req->dev; - VirtIODevice *vdev = VIRTIO_DEVICE(s); trace_virtio_blk_req_complete(req, status); stb_p(&req->in->status, status); virtqueue_push(s->vq, &req->elem, req->in_len); - if (s->dataplane_started && !s->dataplane_disabled) { - virtio_blk_data_plane_notify(s->dataplane); - } else { - virtio_notify(vdev, s->vq); - } + qemu_bh_schedule(s->batch_notify_bh); } static int virtio_blk_handle_rw_error(VirtIOBlockReq *req, int error, @@ -664,6 +681,8 @@ static void virtio_blk_reset(VirtIODevice *vdev) if (s->dataplane) { virtio_blk_data_plane_stop(s->dataplane); } + + virtio_blk_batch_notify_flush(s); aio_context_release(ctx); blk_set_enable_write_cache(s->blk, s->original_wce); @@ -801,6 +820,8 @@ static void virtio_blk_save(QEMUFile *f, void *opaque) virtio_blk_data_plane_stop(s->dataplane); } + virtio_blk_batch_notify_flush(s); + virtio_save(vdev, f); } @@ -896,6 +917,9 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp) return; } + s->batch_notify_bh = aio_bh_new(blk_get_aio_context(s->blk), + virtio_blk_batch_notify_bh, s); + s->change = qemu_add_vm_change_state_handler(virtio_blk_dma_restart_cb, s); register_savevm(dev, "virtio-blk", virtio_blk_id++, 2, virtio_blk_save, virtio_blk_load, s); @@ -910,6 +934,7 @@ static void virtio_blk_device_unrealize(DeviceState *dev, Error **errp) VirtIODevice *vdev = VIRTIO_DEVICE(dev); VirtIOBlock *s = VIRTIO_BLK(dev); + qemu_bh_delete(s->batch_notify_bh); virtio_blk_data_plane_destroy(s->dataplane); s->dataplane = NULL; qemu_del_vm_change_state_handler(s->change); diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h index 8f2b056..b3834bc 100644 --- a/include/hw/virtio/virtio-blk.h +++ b/include/hw/virtio/virtio-blk.h @@ -49,6 +49,7 @@ typedef struct VirtIOBlock { VirtQueue *vq; void *rq; QEMUBH *bh; + QEMUBH *batch_notify_bh; VirtIOBlkConf conf; unsigned short sector_mask; bool original_wce;